linux-kernel - Re: [PATCH next 1/2] octeontx2-pf: fix netdev memory leak in rvu_rep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b97b401b-e318-412b-8344-a856c6e10eca@oracle.com>
Date: Mon, 16 Dec 2024 14:35:50 +0530
From: Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>
To: Przemek Kitszel <przemyslaw.kitszel@...el.com>
Cc: dan.carpenter@...aro.org, kernel-janitors@...r.kernel.org,
        error27@...il.com, Sunil Goutham <sgoutham@...vell.com>,
        Geetha sowjanya <gakula@...vell.com>,
        Subbaraya Sundeep
 <sbhatta@...vell.com>,
        hariprasad <hkelam@...vell.com>,
        Bharat Bhushan <bbhushan2@...vell.com>,
        Andrew Lunn <andrew+netdev@...n.ch>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH next 1/2] octeontx2-pf: fix netdev memory leak in
 rvu_rep_create()

Hi,

On 16/12/24 13:39, Przemek Kitszel wrote:
> On 12/16/24 08:05, Harshit Mogalapalli wrote:
>> When rvu_rep_devlink_port_register() fails, free_netdev(ndev) for this
>> incomplete iteration before going to "exit:" label.
>>
>> Fixes: 3937b7308d4f ("octeontx2-pf: Create representor netdev")
> 

Thanks for the review.
> I would say that you are fixing:
> Fixes: 9ed0343f561e ("octeontx2-pf: Add devlink port support")
> 
Oh right, thank you for catching that. Will fix in V2.
> this is also a -net material

So while sending a V2 I will include [PATCH net-next], that sounds good ?

Thanks,
Harshit