linux-kernel - Re: [RFC][PATCH v021 7/9] PM: EM: Register perf domains with ho :active

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0iwiQVRCpm3Z4HY2S_LANrjWgRSGaQVXFfw12dVBzKdGQ@mail.gmail.com>
Date: Mon, 16 Dec 2024 12:58:57 +0100
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Dietmar Eggemann <dietmar.eggemann@....com>
Cc: "Rafael J. Wysocki" <rjw@...ysocki.net>, Linux PM <linux-pm@...r.kernel.org>, 
	LKML <linux-kernel@...r.kernel.org>, Lukasz Luba <lukasz.luba@....com>, 
	Peter Zijlstra <peterz@...radead.org>, 
	Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>, 
	Morten Rasmussen <morten.rasmussen@....com>, Vincent Guittot <vincent.guittot@...aro.org>, 
	Ricardo Neri <ricardo.neri-calderon@...ux.intel.com>, 
	Pierre Gondois <pierre.gondois@....com>
Subject: Re: [RFC][PATCH v021 7/9] PM: EM: Register perf domains with ho
 :active_power() callbacks

On Mon, Dec 16, 2024 at 11:59 AM Dietmar Eggemann
<dietmar.eggemann@....com> wrote:
>
> On 29/11/2024 17:15, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
>
> In Subject:
>
> with ho :active_power() - without ?
> ^^^^^^^

Sure, thanks!

> [...]
>
> > @@ -594,7 +599,19 @@ int em_dev_register_perf_domain(struct d
> >                        * All CPUs of a domain must have the same
> >                        * micro-architecture since they all share the same
> >                        * table.
> > +                      *
> > +                      * If the :active_power() callback is present, the
> > +                      * performance values for different states in the table
> > +                      * computed by em_create_perf_table() depend on the CPU
> > +                      * capacity which therefore must be the same for all
> > +                      * CPUs in the domain.  However, if the :active_power()
> > +                      * callback is not NULL, em_create_perf_table() doesn't
>
> s/is not NULL/is NULL ?
>
> [...]

Yeah, one negation too many, thanks!