linux-kernel - Re: [PATCH v10 1/4] media: dt-bindings: update clocks for sc7280-camss

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fe28a9bc-82ef-4fef-af50-9d9261ed9b39@kernel.org>
Date: Tue, 17 Dec 2024 17:23:36 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
 Vikram Sharma <quic_vikramsa@...cinc.com>, rfoss@...nel.org,
 todor.too@...il.com, mchehab@...nel.org, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, akapatra@...cinc.com,
 hariramp@...cinc.com, andersson@...nel.org, konradybcio@...nel.org,
 hverkuil-cisco@...all.nl, cros-qcom-dts-watchers@...omium.org,
 catalin.marinas@....com, will@...nel.org
Cc: linux-arm-kernel@...ts.infradead.org, linux-media@...r.kernel.org,
 linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, kernel@...cinc.com
Subject: Re: [PATCH v10 1/4] media: dt-bindings: update clocks for
 sc7280-camss

On 17/12/2024 17:12, Bryan O'Donoghue wrote:
> On 17/12/2024 14:10, Krzysztof Kozlowski wrote:
>> On 17/12/2024 15:06, Vikram Sharma wrote:
>>> This patch change clock names to make it consistent with
>>> existing platforms as gcc_cam_hf_axi -> gcc_axi_hf.
>>> This also adds gcc_axi_sf and remove gcc_camera_ahb.
>>
>> Don't combine ABI changes with some less important things.
>>
>> You miss here explanation why doing the ABI change in the first place.
>> Without that explanation I find it rather churn. But anyway, reason for
>> ABI break and impact should be documented in commit msg.
>>
>>>
>>> Signed-off-by: Vikram Sharma <quic_vikramsa@...cinc.com>
>>> ---
>>
>> Best regards,
>> Krzysztof
> 
> This change should be fine since we haven't committed and upstream dtsi, 
> so there's no ABI to break yet.
> 
> Agree the cover letter should have been explicit in explaining.

So these are recently added bindings (sc7280 is not particularly new)?
If so mention in the commit msg that no users are affected because of this.

Best regards,
Krzysztof