linux-kernel - Re: [PATCH] riscv: dts: starfive: jh7110-common: Use named definition for mmc1 card detect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241217-strained-latch-52bf7d03716d@spud>
Date: Tue, 17 Dec 2024 18:33:14 +0000
From: Conor Dooley <conor@...nel.org>
To: E Shattow <e@...eshell.de>
Cc: Hal Feng <hal.feng@...rfivetech.com>,
	Emil Renner Berthing <kernel@...il.dk>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Paul Walmsley <paul.walmsley@...ive.com>,
	Palmer Dabbelt <palmer@...belt.com>,
	Albert Ou <aou@...s.berkeley.edu>,
	Jianlong Huang <jianlong.huang@...rfivetech.com>,
	Jisheng Zhang <jszhang@...nel.org>,
	Conor Dooley <conor.dooley@...rochip.com>,
	"linux-riscv@...ts.infradead.org" <linux-riscv@...ts.infradead.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Emil Renner Berthing <emil.renner.berthing@...onical.com>
Subject: Re: [PATCH] riscv: dts: starfive: jh7110-common: Use named
 definition for mmc1 card detect

On Mon, Dec 16, 2024 at 07:25:59PM -0800, E Shattow wrote:
> Hi, Hal
> 
> On 12/16/24 18:02, Hal Feng wrote:
> > > On 17.12.24 04:13, Conor Dooley wrote:
> > > On Mon, 09 Dec 2024 20:06:46 -0800, E Shattow wrote:
> > > > Use named definition for mmc1 card detect GPIO instead of numeric literal.
> > > > 
> > > > 
> > > 
> > > Applied to riscv-dt-for-next, thanks!
> > > 
> > > [1/1] riscv: dts: starfive: jh7110-common: Use named definition for mmc1
> > > card detect
> > >        https://git.kernel.org/conor/c/c96f15d79172
> > 
> > No, here "41" means the GPIO number, but GPI_SYS_SDIO1_CD means the
> > multiplexed function and should be used by pinctrl pinmux not gpio subsystem.
> > Although GPI-SYS_SDIO1_CD is numerically the same as 41.
> > 
> > Best regards,
> > Hal
> 
> You're right, Hal. I'm confused trying to make sense of this.
> 
> From dts/upstream/src/riscv/starfive/jh7110-pinfunc.h:
> 
> "gpio nr:  gpio number, 0 - 63"
> 
> And yet in dts/upstream/src/riscv/starfive/jh7110-common.dtsi there's:
> 
> >                        pinmux = <PINMUX(64, 0)>,
> >                                 <PINMUX(65, 0)>,
> >                                 <PINMUX(66, 0)>,
> >                                 <PINMUX(67, 0)>,
> >                                 <PINMUX(68, 0)>,
> >                                 <PINMUX(69, 0)>,
> >                                 <PINMUX(70, 0)>,
> >                                 <PINMUX(71, 0)>,
> >                                 <PINMUX(72, 0)>,
> >                                 <PINMUX(73, 0)>;
> 
> 
> Loosely on the subject of MMC interface and GPIO numbering, what is the
> above code doing? These are not GPIO numbers 0-63 so what is this?
> 
> I'm trying to understand this so I can write the Mars CM (-Lite) dts.
> 


> Conor, and Hal: sorry for the mistake there.

No worries, I've dropped the patch.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)