linux-kernel - Re: [PATCH] riscv: dts: starfive: jh7110-common: Use named definition for mmc1 card detect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bd4df536-0a5d-4ba9-ad0c-51a7828acd9c@freeshell.de>
Date: Mon, 16 Dec 2024 19:25:59 -0800
From: E Shattow <e@...eshell.de>
To: Hal Feng <hal.feng@...rfivetech.com>, Conor Dooley <conor@...nel.org>,
 Emil Renner Berthing <kernel@...il.dk>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Paul Walmsley <paul.walmsley@...ive.com>, Palmer Dabbelt
 <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>,
 Jianlong Huang <jianlong.huang@...rfivetech.com>,
 Jisheng Zhang <jszhang@...nel.org>
Cc: Conor Dooley <conor.dooley@...rochip.com>,
 "linux-riscv@...ts.infradead.org" <linux-riscv@...ts.infradead.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 Emil Renner Berthing <emil.renner.berthing@...onical.com>
Subject: Re: [PATCH] riscv: dts: starfive: jh7110-common: Use named definition
 for mmc1 card detect

Hi, Hal

On 12/16/24 18:02, Hal Feng wrote:
>> On 17.12.24 04:13, Conor Dooley wrote:
>> On Mon, 09 Dec 2024 20:06:46 -0800, E Shattow wrote:
>>> Use named definition for mmc1 card detect GPIO instead of numeric literal.
>>>
>>>
>>
>> Applied to riscv-dt-for-next, thanks!
>>
>> [1/1] riscv: dts: starfive: jh7110-common: Use named definition for mmc1
>> card detect
>>        https://git.kernel.org/conor/c/c96f15d79172
> 
> No, here "41" means the GPIO number, but GPI_SYS_SDIO1_CD means the
> multiplexed function and should be used by pinctrl pinmux not gpio subsystem.
> Although GPI-SYS_SDIO1_CD is numerically the same as 41.
> 
> Best regards,
> Hal

You're right, Hal. I'm confused trying to make sense of this.

 From dts/upstream/src/riscv/starfive/jh7110-pinfunc.h:

"gpio nr:  gpio number, 0 - 63"

And yet in dts/upstream/src/riscv/starfive/jh7110-common.dtsi there's:

 >                        pinmux = <PINMUX(64, 0)>,
 >                                 <PINMUX(65, 0)>,
 >                                 <PINMUX(66, 0)>,
 >                                 <PINMUX(67, 0)>,
 >                                 <PINMUX(68, 0)>,
 >                                 <PINMUX(69, 0)>,
 >                                 <PINMUX(70, 0)>,
 >                                 <PINMUX(71, 0)>,
 >                                 <PINMUX(72, 0)>,
 >                                 <PINMUX(73, 0)>;


Loosely on the subject of MMC interface and GPIO numbering, what is the 
above code doing? These are not GPIO numbers 0-63 so what is this?

I'm trying to understand this so I can write the Mars CM (-Lite) dts.

Conor, and Hal: sorry for the mistake there.

-E