linux-kernel - Re: [PATCH net-next v10 2/2] binder: report txn errors via generic netlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+xfxX6-cbTyyyTf1UL_A7DzagfrV+y0367MdO21+JdjW870ZA@mail.gmail.com>
Date: Mon, 16 Dec 2024 19:53:40 -0800
From: Li Li <dualli@...gle.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Carlos Llamas <cmllamas@...gle.com>, corbet@....net, davem@...emloft.net, 
	Eric Dumazet <edumazet@...gle.com>, pabeni@...hat.com, donald.hunter@...il.com, 
	Greg KH <gregkh@...uxfoundation.org>, Arve Hjønnevåg <arve@...roid.com>, 
	tkjos@...roid.com, maco@...roid.com, 
	"Joel Fernandes (Google)" <joel@...lfernandes.org>, brauner@...nel.org, 
	Suren Baghdasaryan <surenb@...gle.com>, arnd@...db.de, masahiroy@...nel.org, 
	bagasdotme@...il.com, horms@...nel.org, LKML <linux-kernel@...r.kernel.org>, 
	linux-doc@...r.kernel.org, netdev@...r.kernel.org, 
	Hridya Valsaraju <hridya@...gle.com>, Steven Moreland <smoreland@...gle.com>, 
	Android Kernel Team <kernel-team@...roid.com>
Subject: Re: [PATCH net-next v10 2/2] binder: report txn errors via generic netlink

On Mon, Dec 16, 2024, 5:41 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Mon, 16 Dec 2024 10:58:10 -0800 Li Li wrote:
> > > not: There are several places where you have "netlink_nl" which seems
> > > kind of redundant to me. wdyt? IMO you should drop the "nl" in all of
> > > these cases.
> > >
> >
> > These are automatically generated from the yaml file. So let's just
> > keep them as is.
> > But it's a good suggestion to the owner of yaml parser.
>
> I think the unusual naming comes from fact that you call your netlink
> family binder_netlink. It's sort of like adding the word sysfs to the
> name of a sysfs file. I mean the user visible name, not code
> references...
>
> s/binder_netlink/binder/ will clean this up..


I did consider that but unfortunately that would result in a
conflicting binder.h in uapi header.

Probably "binder_report" or "bindererr"?