linux-kernel - Re: [PATCH net-next v10 2/2] binder: report txn errors via generic netlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241216174111.3fdce872@kernel.org>
Date: Mon, 16 Dec 2024 17:41:11 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Li Li <dualli@...omium.org>
Cc: Carlos Llamas <cmllamas@...gle.com>, dualli@...gle.com, corbet@....net,
 davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
 donald.hunter@...il.com, gregkh@...uxfoundation.org, arve@...roid.com,
 tkjos@...roid.com, maco@...roid.com, joel@...lfernandes.org,
 brauner@...nel.org, surenb@...gle.com, arnd@...db.de, masahiroy@...nel.org,
 bagasdotme@...il.com, horms@...nel.org, linux-kernel@...r.kernel.org,
 linux-doc@...r.kernel.org, netdev@...r.kernel.org, hridya@...gle.com,
 smoreland@...gle.com, kernel-team@...roid.com
Subject: Re: [PATCH net-next v10 2/2] binder: report txn errors via generic
 netlink

On Mon, 16 Dec 2024 10:58:10 -0800 Li Li wrote:
> > not: There are several places where you have "netlink_nl" which seems
> > kind of redundant to me. wdyt? IMO you should drop the "nl" in all of
> > these cases.
> >  
> 
> These are automatically generated from the yaml file. So let's just
> keep them as is.
> But it's a good suggestion to the owner of yaml parser.

I think the unusual naming comes from fact that you call your netlink
family binder_netlink. It's sort of like adding the word sysfs to the
name of a sysfs file. I mean the user visible name, not code
references...

s/binder_netlink/binder/ will clean this up..