linux-kernel - Re: [PATCH 5/7] security: Replace get_task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202412161641.8209C666@keescook>
Date: Mon, 16 Dec 2024 16:41:36 -0800
From: Kees Cook <kees@...nel.org>
To: Yafang Shao <laoar.shao@...il.com>
Cc: torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org, linux-security-module@...r.kernel.org,
	x86@...nel.org, linux-snps-arc@...ts.infradead.org,
	linux-wireless@...r.kernel.org, intel-gfx@...ts.freedesktop.org,
	intel-xe@...ts.freedesktop.org, nouveau@...ts.freedesktop.org,
	dri-devel@...ts.freedesktop.org, ocfs2-devel@...ts.linux.dev,
	Paul Moore <paul@...l-moore.com>, James Morris <jmorris@...ei.org>,
	"Serge E. Hallyn" <serge@...lyn.com>
Subject: Re: [PATCH 5/7] security: Replace get_task_comm() with %pTN

On Fri, Dec 13, 2024 at 01:46:08PM +0800, Yafang Shao wrote:
> Since task->comm is guaranteed to be NUL-terminated, we can print it
> directly without the need to copy it into a separate buffer. This
> simplifies the code and avoids unnecessary operations.
> 
> Signed-off-by: Yafang Shao <laoar.shao@...il.com>

Looks good to me; thanks!

Acked-by: Kees Cook <kees@...nel.org>

-- 
Kees Cook