linux-kernel - Re: [PATCH 5/7] security: Replace get_task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHk-=wj=W-4Eu=g83QPUDB+thtL=uY=_1OAVRvXJP=zay+K4Qg@mail.gmail.com>
Date: Mon, 16 Dec 2024 17:08:13 -0800
From: Linus Torvalds <torvalds@...ux-foundation.org>
To: Yafang Shao <laoar.shao@...il.com>
Cc: akpm@...ux-foundation.org, linux-kernel@...r.kernel.org, 
	linux-security-module@...r.kernel.org, x86@...nel.org, 
	linux-snps-arc@...ts.infradead.org, linux-wireless@...r.kernel.org, 
	intel-gfx@...ts.freedesktop.org, intel-xe@...ts.freedesktop.org, 
	nouveau@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org, 
	ocfs2-devel@...ts.linux.dev, Kees Cook <kees@...nel.org>, 
	Paul Moore <paul@...l-moore.com>, James Morris <jmorris@...ei.org>, 
	"Serge E. Hallyn" <serge@...lyn.com>
Subject: Re: [PATCH 5/7] security: Replace get_task_comm() with %pTN

On Thu, 12 Dec 2024 at 21:47, Yafang Shao <laoar.shao@...il.com> wrote:
>
> Since task->comm is guaranteed to be NUL-terminated, we can print it
> directly without the need to copy it into a separate buffer.

So i think we should do the "without copying into a separate buffer"
part of this series, but I do think we should just accept "%s" and
"task->comm".

IOW - getting rid of get_task_comm() is good.

But the "%pTN" pointer format ends up being unnecessary.

          Linus