lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20241218-washtub-certified-90bec5019b12@spud>
Date: Wed, 18 Dec 2024 17:08:35 +0000
From: Conor Dooley <conor@...nel.org>
To: "Miao.Zhu" <Miao.Zhu@...opsys.com>
Cc: gregkh@...uxfoundation.org, robh@...nel.org, xu.yang_2@....com,
	andre.draszik@...aro.org, dan.carpenter@...aro.org,
	emanuele.ghidoli@...adex.com, heikki.krogerus@...ux.intel.com,
	m.felsch@...gutronix.de, rdbabiera@...gle.com,
	u.kleine-koenig@...libre.com, conor+dt@...nel.org, jun.li@....com,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
	devicetree@...r.kernel.org, Jianheng.Zhang@...opsys.com,
	James.Li1@...opsys.com, Martin.McKenny@...opsys.com
Subject: Re: [PATCH v4 2/2] dt-bindings: usb: ptn5110: add TCPC properties

On Wed, Dec 18, 2024 at 09:59:33AM +0100, Miao.Zhu wrote:
> The TCPCI driver has flags to configure its protperties but
> no way to enable these flags yet. Add these flags into DT
> so that the driver can be compatible with TCPCI  Spec R2 V1.0.
> 
> Signed-off-by: Miao.Zhu <miao@...opsys.com>
> ---
> V3 -> V4: refine description to follow DTS coding style

Meanwhile missing the rest of the dt coding style?

> V2 -> V3: add description and type for new properties
> V1 -> V2: new patch
> ---
>  .../devicetree/bindings/usb/nxp,ptn5110.yaml       | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/nxp,ptn5110.yaml b/Documentation/devicetree/bindings/usb/nxp,ptn5110.yaml
> index 65a8632..f5059dc7 100644
> --- a/Documentation/devicetree/bindings/usb/nxp,ptn5110.yaml
> +++ b/Documentation/devicetree/bindings/usb/nxp,ptn5110.yaml
> @@ -21,6 +21,28 @@ properties:
>    interrupts:
>      maxItems: 1
>  
> +  TX_BUF_BYTE_x_hidden:

Is this x a wildcard?
No underscores in property names please, use -s.
Why is this capitalised?
Missing an nxp vendor prefix.
All of these properties should be type flag, not type boolean.

> +    description:
> +      True when TX_BUF_BYTE_x can only be accessed through
> +      I2C_WRITE_BYTE_COUNT.
> +    type: boolean
> +
> +  RX_BUF_BYTE_x_hidden:
> +    description:
> +      True when RX_BUF_BYTE_x can only be accessed through
> +      READABLE_BYTE_COUNT.

Is the I2C_ intentionally left out of the define here?


Cheers,
Conor.

> +    type: boolean
> +
> +  auto_discharge_disconnect:
> +    description:
> +      True when TCPC can autonomously discharge vbus on disconnect.
> +    type: boolean
> +
> +  vbus_vsafe0v:
> +    description:
> +      True when TCPC can detect whether vbus is at VSAFE0V.
> +    type: boolean
> +
>    connector:
>      type: object
>      $ref: /schemas/connector/usb-connector.yaml#
> -- 
> 2.9.3
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ