linux-kernel - Re: [PATCH v4 2/2] dt-bindings: usb: ptn5110: add TCPC properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aab43d50-343f-4fd5-b55e-e475b7171979@kernel.org>
Date: Thu, 19 Dec 2024 09:02:21 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: "Miao.Zhu" <Miao.Zhu@...opsys.com>, gregkh@...uxfoundation.org,
 robh@...nel.org, xu.yang_2@....com, andre.draszik@...aro.org,
 dan.carpenter@...aro.org, emanuele.ghidoli@...adex.com,
 heikki.krogerus@...ux.intel.com, m.felsch@...gutronix.de,
 rdbabiera@...gle.com, u.kleine-koenig@...libre.com, conor+dt@...nel.org,
 jun.li@....com
Cc: linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
 devicetree@...r.kernel.org, Jianheng.Zhang@...opsys.com,
 James.Li1@...opsys.com, Martin.McKenny@...opsys.com
Subject: Re: [PATCH v4 2/2] dt-bindings: usb: ptn5110: add TCPC properties

On 18/12/2024 09:59, Miao.Zhu wrote:
> The TCPCI driver has flags to configure its protperties but
> no way to enable these flags yet. Add these flags into DT
> so that the driver can be compatible with TCPCI  Spec R2 V1.0.
> 
> Signed-off-by: Miao.Zhu <miao@...opsys.com>
> ---
> V3 -> V4: refine description to follow DTS coding style

Nothing improved.

> V2 -> V3: add description and type for new properties
> V1 -> V2: new patch
> ---
>  .../devicetree/bindings/usb/nxp,ptn5110.yaml       | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/nxp,ptn5110.yaml b/Documentation/devicetree/bindings/usb/nxp,ptn5110.yaml
> index 65a8632..f5059dc7 100644
> --- a/Documentation/devicetree/bindings/usb/nxp,ptn5110.yaml
> +++ b/Documentation/devicetree/bindings/usb/nxp,ptn5110.yaml
> @@ -21,6 +21,28 @@ properties:
>    interrupts:
>      maxItems: 1
>  
> +  TX_BUF_BYTE_x_hidden:

You did not implement my comments.

<form letter>
This is a friendly reminder during the review process.

It seems my or other reviewer's previous comments were not fully
addressed. Maybe the feedback got lost between the quotes, maybe you
just forgot to apply it. Please go back to the previous discussion and
either implement all requested changes or keep discussing them.

Thank you.
</form letter>

Best regards,
Krzysztof