linux-kernel - Re: [PATCH v9 1/1] mctp pcc: Implement MCTP over PCC Transport

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0ea0aac339c2ee7522510f1dab5f69a27413434d.camel@codeconstruct.com.au>
Date: Wed, 18 Dec 2024 08:09:20 +0800
From: Jeremy Kerr <jk@...econstruct.com.au>
To: Joe Damato <jdamato@...tly.com>, admiyo@...amperecomputing.com
Cc: Matt Johnston <matt@...econstruct.com.au>, Andrew Lunn
 <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo
 Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org,  Sudeep Holla <sudeep.holla@....com>,
 Jonathan Cameron <Jonathan.Cameron@...wei.com>, Huisong Li
 <lihuisong@...wei.com>
Subject: Re: [PATCH v9 1/1] mctp pcc: Implement MCTP over PCC Transport

Hi Joe,

> I suspect what Jeremy meant (but please feel free to correct me if
> I'm mistaken, Jeremy) was that you may want to use the helpers in:
> 
> include/linux/netdevice.h

No, I was just referring to the new(-ish) dstats infrastructure in the
core, with dstats collection in rtnl_link_stats64() as of 94b601bc.

However, your suggestion of:

>   dev_dstats_rx_add(mctp_pcc_ndev->mdev.dev, data_len);
>   dev_dstats_rx_dropped(mctp_pcc_ndev->mdev.dev);

make it even simpler! I would agree with the recommendation there.

Cheers,

Jeremy