linux-kernel - Re: [PATCH v2] loongarch/mm: disable WUC for pgprot_writecombine as same as ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0f3989e46dd24a0c972482ea570907e5d8cae87e.camel@icenowy.me>
Date: Wed, 18 Dec 2024 14:23:31 +0800
From: Icenowy Zheng <uwu@...nowy.me>
To: Sui Jingfeng <sui.jingfeng@...ux.dev>, Shuah <shuah@...nel.org>, Xi
 Ruoyao <xry111@...111.site>, WANG Xuerui <kernel@...0n.name>, Huacai Chen
 <chenhuacai@...nel.org>
Cc: Andrew Morton <akpm@...ux-foundation.org>, "Mike Rapoport (IBM)"
 <rppt@...nel.org>, Baoquan He <bhe@...hat.com>, "Matthew Wilcox (Oracle)"
 <willy@...radead.org>, David Hildenbrand <david@...hat.com>, Zhen Lei
 <thunder.leizhen@...wei.com>, Thomas Gleixner <tglx@...utronix.de>, Zhihong
 Dong <donmor3000@...mail.com>, loongarch@...ts.linux.dev,
 linux-kernel@...r.kernel.org,  "conduct@...nel.org" <conduct@...nel.org>
Subject: Re: [PATCH v2] loongarch/mm: disable WUC for pgprot_writecombine as
 same as ioremap_wc

在 2024-12-18星期三的 11:24 +0800，Sui Jingfeng写道：
> Hi,
> 
> 
> On 2024/12/18 02:18, Shuah wrote:
> > On 12/2/24 09:23, Sui Jingfeng wrote:
> > > Hi,
> > > 
> > 
> > > > IIUC this is a hardware bug of 7A1000 and 7A2000, so the proper
> > > > location
> > > > of the workaround is in the bridge chip driver.  Or am I
> > > > misunderstanding something?
> > > > 
> > > 
> > > You are misunderstanding everything and ranting like a dog.
> > > 
> > 
> > Sui Jingfeng,
> > 
> > This is not the way to work with your fellow developers in the
> > community to express disagreements.
> 
> 
> I'm not expressing disagreements, but argue that the contributor
> and/or talker should provide *sufficient* hardware details and
> tests. Instead of pointless *ranting* in order to get harmful
> patch merged.

I don't think the original patch is harmful.

It changes wrong things to corect, do not break known-good things,
although I assume it will slightly harm the performance -- but I think
performance w/o correctness is just meaningless. In the perspective of
graphics, you can nearly always "enhance your performance" by sending
everything to /dev/null and pretend them to be done.

> 
> The discussion completely not make scene at all.
> 
> 
> > I would recommend following up with an apology.
> > 
> 
> I will not apology to indecent contributors and/or maintainers
> like this, never.
> 
> 
> > thanks,
> > -- Shuah
> > 
> > 
> > 
> > 
> >