linux-kernel - Re: [PATCH v2] loongarch/mm: disable WUC for pgprot_writecombine as same as ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0ca63dfb-ece7-4ea5-a61c-a80fa0567c4d@linux.dev>
Date: Wed, 18 Dec 2024 18:05:59 +0800
From: Sui Jingfeng <sui.jingfeng@...ux.dev>
To: Icenowy Zheng <uwu@...nowy.me>, Shuah <shuah@...nel.org>,
 Xi Ruoyao <xry111@...111.site>, WANG Xuerui <kernel@...0n.name>,
 Huacai Chen <chenhuacai@...nel.org>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
 "Mike Rapoport (IBM)" <rppt@...nel.org>, Baoquan He <bhe@...hat.com>,
 "Matthew Wilcox (Oracle)" <willy@...radead.org>,
 David Hildenbrand <david@...hat.com>, Zhen Lei <thunder.leizhen@...wei.com>,
 Thomas Gleixner <tglx@...utronix.de>, Zhihong Dong <donmor3000@...mail.com>,
 loongarch@...ts.linux.dev, linux-kernel@...r.kernel.org,
 "conduct@...nel.org" <conduct@...nel.org>
Subject: Re: [PATCH v2] loongarch/mm: disable WUC for pgprot_writecombine as
 same as ioremap_wc

Hi,


On 2024/12/18 14:23, Icenowy Zheng wrote:
> 在 2024-12-18星期三的 11:24 +0800，Sui Jingfeng写道：
>> Hi,
>>
>>
>> On 2024/12/18 02:18, Shuah wrote:
>>> On 12/2/24 09:23, Sui Jingfeng wrote:
>>>> Hi,
>>>>
>>>>> IIUC this is a hardware bug of 7A1000 and 7A2000, so the proper
>>>>> location
>>>>> of the workaround is in the bridge chip driver.  Or am I
>>>>> misunderstanding something?
>>>>>
>>>> You are misunderstanding everything and ranting like a dog.
>>>>
>>> Sui Jingfeng,
>>>
>>> This is not the way to work with your fellow developers in the
>>> community to express disagreements.
>>
>> I'm not expressing disagreements, but argue that the contributor
>> and/or talker should provide *sufficient* hardware details and
>> tests. Instead of pointless *ranting* in order to get harmful
>> patch merged.
> I don't think the original patch is harmful.
>

I have told you countless times, that is, disabling Write-Combine
made the performance of BMC graphics(drm/ast) decrease dramatically.

And downstream Loongson developer really dislike related patch,
and asking for solutions to me.


>> The discussion completely not make scene at all.
>>
>>
>>> I would recommend following up with an apology.
>>>
>> I will not apology to indecent contributors and/or maintainers
>> like this, never.
>>
>>
>>> thanks,
>>> -- Shuah
>>>
>>>
>>>
>>>
>>>
-- 
Best regards,
Sui