linux-kernel - Re: [PATCH v3 2/2] dt-bindings: usb: ptn5110: add TCPC properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fbad3631-1efe-4d9b-b163-e635452b0b73@kernel.org>
Date: Wed, 18 Dec 2024 09:04:01 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: "Miao.Zhu" <Miao.Zhu@...opsys.com>, robh@...nel.org
Cc: James.Li1@...opsys.com, Jianheng.Zhang@...opsys.com,
 Martin.McKenny@...opsys.com, andre.draszik@...aro.org, conor+dt@...nel.org,
 dan.carpenter@...aro.org, devicetree@...r.kernel.org,
 emanuele.ghidoli@...adex.com, gregkh@...uxfoundation.org,
 heikki.krogerus@...ux.intel.com, jun.li@....com,
 linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
 m.felsch@...gutronix.de, rdbabiera@...gle.com, u.kleine-koenig@...libre.com,
 xu.yang_2@....com
Subject: Re: [PATCH v3 2/2] dt-bindings: usb: ptn5110: add TCPC properties

On 18/12/2024 06:22, Miao.Zhu wrote:
> From: Miao Zhu <miao@...opsys.com>
> 
> The TCPCI driver has flags to configure its protperties but
> no way to enable these flags yet. Add these flags into DT
> so that the driver can be compatible with TCPCI  Spec R2 V1.0.

Do not attach (thread) your patchsets to some other threads (unrelated
or older versions). This buries them deep in the mailbox and might
interfere with applying entire sets.

<form letter>
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC (and consider --no-git-fallback argument, so you will
not CC people just because they made one commit years ago). It might
happen, that command when run on an older kernel, gives you outdated
entries. Therefore please be sure you base your patches on recent Linux
kernel.

Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.
</form letter>

> 
> Signed-off-by: Miao.Zhu <miao@...opsys.com>
> ---
> V2 -> V3: Add description and type for new properties:
> ---
>  .../devicetree/bindings/usb/nxp,ptn5110.yaml       | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/nxp,ptn5110.yaml b/Documentation/devicetree/bindings/usb/nxp,ptn5110.yaml
> index 65a8632..29d6aed 100644
> --- a/Documentation/devicetree/bindings/usb/nxp,ptn5110.yaml
> +++ b/Documentation/devicetree/bindings/usb/nxp,ptn5110.yaml
> @@ -21,6 +21,28 @@ properties:
>    interrupts:
>      maxItems: 1
>  
> +  TX_BUF_BYTE_x_hidden:

Follow DTS coding style.

> +    description:
> +      When set, TX_BUF_BYTE_x can only be accessed through
> +      I2C_WRITE_BYTE_COUNT.
You described the desired Linux feature or behavior, not the actual
hardware. The bindings are about the latter, so instead you need to
rephrase the property and its description to match actual hardware
capabilities/features/configuration etc.

Best regards,
Krzysztof