linux-kernel - Re: [PATCH v3 2/2] dt-bindings: usb: ptn5110: add TCPC properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bdbff25d-fe9d-4602-add5-aa2f9d4806d1@kernel.org>
Date: Wed, 18 Dec 2024 10:04:31 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: "Miao.Zhu" <Miao.Zhu@...opsys.com>, robh@...nel.org
Cc: James.Li1@...opsys.com, Jianheng.Zhang@...opsys.com,
 Martin.McKenny@...opsys.com, andre.draszik@...aro.org, conor+dt@...nel.org,
 dan.carpenter@...aro.org, devicetree@...r.kernel.org,
 emanuele.ghidoli@...adex.com, gregkh@...uxfoundation.org,
 heikki.krogerus@...ux.intel.com, jun.li@....com,
 linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
 m.felsch@...gutronix.de, rdbabiera@...gle.com, u.kleine-koenig@...libre.com,
 xu.yang_2@....com
Subject: Re: [PATCH v3 2/2] dt-bindings: usb: ptn5110: add TCPC properties

On 18/12/2024 09:04, Krzysztof Kozlowski wrote:
>>    interrupts:
>>      maxItems: 1
>>  
>> +  TX_BUF_BYTE_x_hidden:
> 
> Follow DTS coding style.
> 
>> +    description:
>> +      When set, TX_BUF_BYTE_x can only be accessed through
>> +      I2C_WRITE_BYTE_COUNT.
> You described the desired Linux feature or behavior, not the actual
> hardware. The bindings are about the latter, so instead you need to
> rephrase the property and its description to match actual hardware
> capabilities/features/configuration etc.

I forgot: missing vendor prefix, missing type. Please see how other
bindings are written. example-schema is also good to start with.

Best regards,
Krzysztof