linux-kernel - RE: [RESEND PATCH v5 1/3] dt-bindings: PCI: dwc: Add AMD Versal2 mdb slcr support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <SN7PR12MB72019397436F94C7E2D915118B052@SN7PR12MB7201.namprd12.prod.outlook.com>
Date: Wed, 18 Dec 2024 09:30:17 +0000
From: "Havalige, Thippeswamy" <thippeswamy.havalige@....com>
To: Rob Herring <robh@...nel.org>
CC: "bhelgaas@...gle.com" <bhelgaas@...gle.com>, "lpieralisi@...nel.org"
	<lpieralisi@...nel.org>, "kw@...ux.com" <kw@...ux.com>,
	"manivannan.sadhasivam@...aro.org" <manivannan.sadhasivam@...aro.org>,
	"krzk+dt@...nel.org" <krzk+dt@...nel.org>, "conor+dt@...nel.org"
	<conor+dt@...nel.org>, "linux-pci@...r.kernel.org"
	<linux-pci@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "jingoohan1@...il.com"
	<jingoohan1@...il.com>, "Simek, Michal" <michal.simek@....com>, "Gogada,
 Bharat Kumar" <bharat.kumar.gogada@....com>
Subject: RE: [RESEND PATCH v5 1/3] dt-bindings: PCI: dwc: Add AMD Versal2 mdb
 slcr support

Hi Rob,
> -----Original Message-----
> From: Rob Herring <robh@...nel.org>
> Sent: Tuesday, December 17, 2024 8:31 PM
> To: Havalige, Thippeswamy <thippeswamy.havalige@....com>
> Cc: bhelgaas@...gle.com; lpieralisi@...nel.org; kw@...ux.com;
> manivannan.sadhasivam@...aro.org; krzk+dt@...nel.org; conor+dt@...nel.org;
> linux-pci@...r.kernel.org; devicetree@...r.kernel.org; linux-
> kernel@...r.kernel.org; jingoohan1@...il.com; Simek, Michal
> <michal.simek@....com>; Gogada, Bharat Kumar
> <bharat.kumar.gogada@....com>
> Subject: Re: [RESEND PATCH v5 1/3] dt-bindings: PCI: dwc: Add AMD Versal2 mdb
> slcr support
> 
> On Fri, Dec 13, 2024 at 12:10:33PM +0530, Thippeswamy Havalige wrote:
> > Add support for mdb slcr aperture that is only supported for AMD
> > Versal2 devices.
> >
> > Signed-off-by: Thippeswamy Havalige <thippeswamy.havalige@....com>
> > ---
> > Changes in v3:
> > -------------
> > - Introduced below changes in dwc yaml schema.
> > Changes in v5:
> > -------------
> > - Modify mdb_pcie_slcr as constant.
> > ---
> >  Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml
> > b/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml
> > index 548f59d76ef2..696568e81cfc 100644
> > --- a/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml
> > +++ b/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml
> > @@ -113,6 +113,8 @@ properties:
> >                enum: [ smu, mpu ]
> >              - description: Tegra234 aperture
> >                enum: [ ecam ]
> > +            - description: AMD MDB PCIe slcr region
> > +              const: mdb_pcie_slcr
> 
> Including the block name is redundant. Just 'slcr' is sufficient.
Thank you for your comments, I'll update this in next patch.
> 
> >      allOf:
> >        - contains:
> >            const: dbi
> > --
> > 2.34.1
> >