[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <f6527df3-feb9-4d3b-93d7-84f4f255d23c@quicinc.com>
Date: Wed, 18 Dec 2024 16:45:18 +0530
From: Manikanta Mylavarapu <quic_mmanikan@...cinc.com>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>,
<srinivas.kandagatla@...aro.org>, <robh@...nel.org>,
<krzk+dt@...nel.org>, <conor+dt@...nel.org>, <amitk@...nel.org>,
<thara.gopinath@...il.com>, <rafael@...nel.org>,
<daniel.lezcano@...aro.org>, <rui.zhang@...el.com>,
<lukasz.luba@....com>, <andersson@...nel.org>,
<konradybcio@...nel.org>, <linux-arm-msm@...r.kernel.org>,
<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<linux-pm@...r.kernel.org>
CC: <quic_srichara@...cinc.com>, <quic_varada@...cinc.com>
Subject: Re: [PATCH v9 4/7] arm64: dts: qcom: ipq5332: Add tsens node
On 12/13/2024 6:29 PM, Konrad Dybcio wrote:
> On 25.11.2024 6:07 AM, Manikanta Mylavarapu wrote:
>> From: Praveenkumar I <quic_ipkumar@...cinc.com>
>>
>> IPQ5332 has tsens v2.3.3 peripheral. This patch adds the tsens
>> node with nvmem cells for calibration data.
>>
>> Signed-off-by: Praveenkumar I <quic_ipkumar@...cinc.com>
>> Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@...cinc.com>
>> ---
>
> [...]
>
>>
>> + tsens: thermal-sensor@...000 {
>> + compatible = "qcom,ipq5332-tsens";
>> + reg = <0x004a9000 0x1000>,
>> + <0x004a8000 0x1000>;
>> + nvmem-cells = <&tsens_mode>,
>> + <&tsens_base0>,
>> + <&tsens_base1>,
>> + <&tsens_sens11_off>,
>> + <&tsens_sens12_off>,
>> + <&tsens_sens13_off>,
>> + <&tsens_sens14_off>,
>> + <&tsens_sens15_off>;
>> + nvmem-cell-names = "mode",
>> + "base0",
>> + "base1",
>> + "tsens_sens11_off",
>> + "tsens_sens12_off",
>> + "tsens_sens13_off",
>> + "tsens_sens14_off",
>> + "tsens_sens15_off";
>> + interrupts = <GIC_SPI 320 IRQ_TYPE_LEVEL_HIGH>;
>> + interrupt-names = "combined";
>
> Please move interrupts properties above nvmem
>
Sure, i will move in next version.
Thanks & Regards,
Manikanta.
> with that:
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
>
> Konrad
Powered by blists - more mailing lists