linux-kernel - Re: [PATCH v9 6/7] arm64: dts: qcom: ipq5424: Add tsens node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b0fb1528-d542-4436-9761-cb5b5bb84df3@quicinc.com>
Date: Wed, 18 Dec 2024 16:47:45 +0530
From: Manikanta Mylavarapu <quic_mmanikan@...cinc.com>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>,
        <srinivas.kandagatla@...aro.org>, <robh@...nel.org>,
        <krzk+dt@...nel.org>, <conor+dt@...nel.org>, <amitk@...nel.org>,
        <thara.gopinath@...il.com>, <rafael@...nel.org>,
        <daniel.lezcano@...aro.org>, <rui.zhang@...el.com>,
        <lukasz.luba@....com>, <andersson@...nel.org>,
        <konradybcio@...nel.org>, <linux-arm-msm@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-pm@...r.kernel.org>
CC: <quic_srichara@...cinc.com>, <quic_varada@...cinc.com>
Subject: Re: [PATCH v9 6/7] arm64: dts: qcom: ipq5424: Add tsens node



On 12/13/2024 6:30 PM, Konrad Dybcio wrote:
> On 25.11.2024 6:07 AM, Manikanta Mylavarapu wrote:
>> IPQ5424 has tsens v2.3.3 peripheral. This patch adds the tsens
>> node with nvmem cells for calibration data.
>>
>> Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@...cinc.com>
>> ---
> 
> [...]
> 
>> +		tsens: thermal-sensor@...000 {
>> +			compatible = "qcom,ipq5424-tsens";
>> +			reg = <0 0x004a9000 0 0x1000>,
>> +			      <0 0x004a8000 0 0x1000>;
>> +			nvmem-cells = <&tsens_mode>,
>> +				      <&tsens_base0>,
>> +				      <&tsens_base1>,
>> +				      <&tsens_sens9_off>,
>> +				      <&tsens_sens10_off>,
>> +				      <&tsens_sens11_off>,
>> +				      <&tsens_sens12_off>,
>> +				      <&tsens_sens13_off>,
>> +				      <&tsens_sens14_off>,
>> +				      <&tsens_sens15_off>;
>> +			nvmem-cell-names = "mode",
>> +					   "base0",
>> +					   "base1",
>> +					   "tsens_sens9_off",
>> +					   "tsens_sens10_off",
>> +					   "tsens_sens11_off",
>> +					   "tsens_sens12_off",
>> +					   "tsens_sens13_off",
>> +					   "tsens_sens14_off",
>> +					   "tsens_sens15_off";
>> +			interrupts = <GIC_SPI 105 IRQ_TYPE_EDGE_RISING>;
>> +			interrupt-names = "combined";
>> +			#qcom,sensors = <7>;
>> +			#thermal-sensor-cells = <1>;
>> +		};
> 
> Please move interrupts properties above nvmem
> 

Sure, i will update in the next version.

Thanks & Regards,
Manikanta.

> with that:
> 
> Reviewed-by: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
> 
> Konrad