linux-kernel - Re: [PATCH v3 00/19] Disable USB U1/U2 entry for QC targets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e15bc97d-eef3-4e49-badf-5b3afbc113d9@quicinc.com>
Date: Wed, 18 Dec 2024 17:18:50 +0530
From: Prashanth K <quic_prashk@...cinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
CC: Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio
	<konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski
	<krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Krishna Kurapati
	<krishna.kurapati@....qualcomm.com>,
        <linux-kernel@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <cros-qcom-dts-watchers@...omium.org>
Subject: Re: [PATCH v3 00/19] Disable USB U1/U2 entry for QC targets



On 18-12-24 04:57 pm, Dmitry Baryshkov wrote:
> On Wed, Dec 18, 2024 at 03:56:48PM +0530, Prashanth K wrote:
>> Enabling U1 and U2 power-saving states can lead to stability and
>> performance issues, particularly for latency-sensitive or high-
>> throughput applications. These low-power link states are intended
>> to reduce power consumption by allowing the device to enter partial
>> low-power modes during idle periods. However, they can sometimes
>> result in unexpected behavior. Over the years, some of the issues
>> seen are as follows:
>>
> 
> [..]
> 
>>
>> This series was earlier started by Krishna Kurapati where he disabled
>> U1/U2 on some SM targets. I'm extending this to more devices including
>> Auto, Compute and IOT platforms. On a side note, this quirk has been
>> already included on some mobile targets like SM8550/8650.
> 
> Why are you resending previous patches rather than adding another series
> on top of it?
> 
Hi Dmitry,

RFC had only one patch with quirks (to disable u1/u2) only for few
targets (SM8150, 8250, 8350, 8450). It was later decided to split it
into per-file commits as per the review comments. Hence I clubbed
Krishna's changes along with few more targets. Let me know if this needs
to be changed.

>>
>> Changes in v2:
>> - Removed the wrongly added quirks from tcsr_mutex node.
>> - Link to v2: https://lore.kernel.org/all/20241213095237.1409174-1-quic_prashk@quicinc.com/
> 
> What was changed in v3?
It was supposed to be "Changes in v3" instead of v2.
> 
>>
>> Link to RFC:
>> https://lore.kernel.org/all/20241107073650.13473-1-quic_kriskura@quicinc.com/#Z31arch:arm64:boot:dts:qcom:sm8250.dtsi
>>
> 
Regards,
Prashanth K