linux-kernel - Re: [PATCH 7/8] dmaengine: fsl-edma: wait until no hardware request is in progress

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <60b8eef7-e946-4e86-9116-46fadbafb53d@kernel.org>
Date: Wed, 18 Dec 2024 14:32:59 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Larisa Ileana Grigore <larisa.grigore@....nxp.com>, Frank.Li@....com
Cc: dmaengine@...r.kernel.org, imx@...ts.linux.dev,
 linux-kernel@...r.kernel.org, s32@....com,
 Christophe Lizzi <clizzi@...hat.com>, Alberto Ruiz <aruizrui@...hat.com>,
 Enric Balletbo <eballetb@...hat.com>
Subject: Re: [PATCH 7/8] dmaengine: fsl-edma: wait until no hardware request
 is in progress

On 18/12/2024 14:24, Larisa Ileana Grigore wrote:
>>>
>>> Thank you for you review Krzysztof! Indeed, this commit should be moved
>>> right after "dmaengine: fsl-edma: add eDMAv3 registers to edma_regs"
>>
>> I don't understand this. Are you saying you introduce bug in one patch
>> and fix in other? Why this cannot be separate patchset?
> 
> The bug was introduced by 72f5801a4e2b7 ("dmaengine: fsl-edma: integrate 
> v3 support"), commit which is already upstream.
> 
> In the proposed fix, a channel is disabled after checking the HRS 
> register which is a eDMAv3 specific register.
> 
> In the upstream implementation, "struct edma_regs" is created based on 
> the eDMAv2 register layout [1] which is different compared to the eDMAv3 
> register layout.
> The "hrs" field, which is used to access the HRS register, was 
> introduced in one of the patches from this set [2].
> So, this fix depends on two other commits:
> "dmaengine: fsl-edma: add eDMAv3 registers to edma_regs"  [2]
> "dmaengine: fsl-edma: move eDMAv2 related registers to a new structure 
> ’edma2_regs’" [3]

OK, this explains the problem. Your fix cannot depend on other patches.


Best regards,
Krzysztof