linux-kernel - Re: [PATCH V4] scsi: ufs: qcom: Enable UFS Shared ICE Feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eadb98dd-f482-4479-8ff8-dcf301edf18c@acm.org>
Date: Thu, 19 Dec 2024 09:23:33 -0800
From: Bart Van Assche <bvanassche@....org>
To: Ram Kumar Dwivedi <quic_rdwivedi@...cinc.com>,
 manivannan.sadhasivam@...aro.org, James.Bottomley@...senPartnership.com,
 martin.petersen@...cle.com, andersson@...nel.org
Cc: linux-arm-msm@...r.kernel.org, linux-scsi@...r.kernel.org,
 linux-kernel@...r.kernel.org,
 Naveen Kumar Goud Arepalli <quic_narepall@...cinc.com>,
 Nitin Rawat <quic_nitirawa@...cinc.com>
Subject: Re: [PATCH V4] scsi: ufs: qcom: Enable UFS Shared ICE Feature

On 12/18/24 10:16 PM, Ram Kumar Dwivedi wrote:
> On 18-Dec-24 10:49 PM, Bart Van Assche wrote:
>> On 12/18/24 7:11 AM, Ram Kumar Dwivedi wrote:
>>> +    uint8_t val[4] = { NUM_RX_R1W0, NUM_TX_R0W1, NUM_RX_R1W1, NUM_TX_R1W1 };
>>
>> This array can be declared 'static const', isn't it?
> 
> As this value is not modified in this function, we will declare it as const in next patchset

Why only 'const'? Why not 'static const' as everyone else does for this
type of arrays?

Thanks,

Bart.