linux-kernel - Re: [PATCH V4] scsi: ufs: qcom: Enable UFS Shared ICE Feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <69503b23-12da-4270-9910-9440dba7df07@quicinc.com>
Date: Thu, 19 Dec 2024 11:46:12 +0530
From: Ram Kumar Dwivedi <quic_rdwivedi@...cinc.com>
To: Bart Van Assche <bvanassche@....org>, <manivannan.sadhasivam@...aro.org>,
        <James.Bottomley@...senPartnership.com>, <martin.petersen@...cle.com>,
        <andersson@...nel.org>
CC: <linux-arm-msm@...r.kernel.org>, <linux-scsi@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        Naveen Kumar Goud Arepalli
	<quic_narepall@...cinc.com>,
        Nitin Rawat <quic_nitirawa@...cinc.com>
Subject: Re: [PATCH V4] scsi: ufs: qcom: Enable UFS Shared ICE Feature



On 18-Dec-24 10:49 PM, Bart Van Assche wrote:
> On 12/18/24 7:11 AM, Ram Kumar Dwivedi wrote:
>> +static void ufs_qcom_config_ice_allocator(struct ufs_qcom_host *host)
>> +{
>> +    struct ufs_hba *hba = host->hba;
>> +    uint8_t val[4] = { NUM_RX_R1W0, NUM_TX_R0W1, NUM_RX_R1W1, NUM_TX_R1W1 };
> 
> This array can be declared 'static const', isn't it?

Hi Bart,
As this value is not modified in this function, we will declare it as const in next patchset
> 
>> +    u32 config;
>> +
>> +    if (!is_ice_config_supported(host))
>> +        return;
>> +
>> +    config = val[0] | (val[1] << 8) | (val[2] << 16) | (val[3] << 24);
> 
> Isn't this is an open-coded version of get_unaligned_le32()?
sure will make the suggested change in next patchset

Thanks,
Ram.

> 
> Thanks,
> 
> Bart.