linux-kernel - Re: [PATCH-next] RDMA/erdma: Fix opcode conditional check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <37815931-4b7d-35af-fde4-9f3007ee99d9@linux.alibaba.com>
Date: Thu, 19 Dec 2024 13:40:50 +0800
From: Cheng Xu <chengyou@...ux.alibaba.com>
To: Advait Dhamorikar <advaitdhamorikar@...il.com>,
 Kai Shen <kaishen@...ux.alibaba.com>, Jason Gunthorpe <jgg@...pe.ca>,
 Leon Romanovsky <leon@...nel.org>
Cc: linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH-next] RDMA/erdma: Fix opcode conditional check



On 12/19/24 12:39 PM, Advait Dhamorikar wrote:
> Fix conditional if else check by checking with wr->opcode.
> The indicated dead code may have performed some action; that
> action will never occur as op is pre-assigned a different value.
> 
> Signed-off-by: Advait Dhamorikar <advaitdhamorikar@...il.com>
> ---
>  drivers/infiniband/hw/erdma/erdma_qp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Reviewed-by: Cheng Xu <chengyou@...ux.alibaba.com>

Thanks very much,
Cheng Xu

> diff --git a/drivers/infiniband/hw/erdma/erdma_qp.c b/drivers/infiniband/hw/erdma/erdma_qp.c
> index 4dfb4272ad86..5c266918fb36 100644
> --- a/drivers/infiniband/hw/erdma/erdma_qp.c
> +++ b/drivers/infiniband/hw/erdma/erdma_qp.c
> @@ -406,7 +406,7 @@ static void init_send_sqe_rc(struct erdma_qp *qp, struct erdma_send_sqe_rc *sqe,
>  	if (wr->opcode == IB_WR_SEND_WITH_IMM) {
>  		op = ERDMA_OP_SEND_WITH_IMM;
>  		sqe->imm_data = wr->ex.imm_data;
> -	} else if (op == IB_WR_SEND_WITH_INV) {
> +	} else if (wr->opcode == IB_WR_SEND_WITH_INV) {
>  		op = ERDMA_OP_SEND_WITH_INV;
>  		sqe->invalid_stag = cpu_to_le32(wr->ex.invalidate_rkey);
>  	}