linux-kernel - Re: [PATCH] kunit: platform: Resolve 'struct completion' warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABVgOSm=mo_o_KoSwyA_rpTuWwzoeXcBKY5ynrE6Bvjk7i5mHw@mail.gmail.com>
Date: Thu, 19 Dec 2024 13:41:11 +0800
From: David Gow <davidgow@...gle.com>
To: Brian Norris <briannorris@...omium.org>
Cc: Brendan Higgins <brendan.higgins@...ux.dev>, Rae Moar <rmoar@...gle.com>, 
	kunit-dev@...glegroups.com, linux-kernel@...r.kernel.org, 
	linux-kselftest@...r.kernel.org
Subject: Re: [PATCH] kunit: platform: Resolve 'struct completion' warning

On Sat, 14 Dec 2024 at 02:09, Brian Norris <briannorris@...omium.org> wrote:
>
> If the <kunit/platform_device.h> header is included in a test without
> certain other headers, it produces compiler warnings like:
>
> In file included from [...]
> ../include/kunit/platform_device.h:15:57: warning: ‘struct completion’
> declared inside parameter list will not be visible outside of this
> definition or declaration
>    15 |                                                  struct completion *x);
>       |                                                         ^~~~~~~~~~
>
> Add a 'struct completion' forward declaration to resolve this.
>
> Signed-off-by: Brian Norris <briannorris@...omium.org>
> ---
> I'm not bothering with a Fixes tag, since this only shows up with new
> tests I'm writing.
>

Nice catch, thanks!

Reviewed-by: David Gow <davidgow@...gle.com>

Cheers,
-- David

Download attachment "smime.p7s" of type "application/pkcs7-signature" (5294 bytes)