linux-kernel - Re: [RFC PATCH 2/4] dt-bindings: iio: adc: Add AD4170

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241219140704.2d06403f@jic23-huawei>
Date: Thu, 19 Dec 2024 14:07:04 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Rob Herring <robh@...nel.org>
Cc: Marcelo Schmitt <marcelo.schmitt@...log.com>, linux-iio@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, lars@...afoo.de,
 Michael.Hennerich@...log.com, krzk+dt@...nel.org, conor+dt@...nel.org,
 ana-maria.cusco@...log.com, marcelo.schmitt1@...il.com
Subject: Re: [RFC PATCH 2/4] dt-bindings: iio: adc: Add AD4170

On Wed, 18 Dec 2024 13:48:04 -0600
Rob Herring <robh@...nel.org> wrote:

> On Wed, Dec 18, 2024 at 11:37:42AM -0300, Marcelo Schmitt wrote:
> > Add device tree documentation for AD4170 sigma-delta ADCs.
> >   
> 
> The usual question with long lists of properties. Any of these should be 
> run-time controlled (by userspace) instead? If they might vary by the 
> user for given h/w design, then should be user controlled instead.

Hi Rob,

I took a look and mostly make sense in DT as they are hardware design
things as it's all about driving an external bridge circuit for
which there will be a correct configuration.

There were a few exceptions however hiding in amongst them!

ADCs that support Wheatstone bridge operations are probably my least
favourite drivers to review.  Very very fiddly as they have
complex (and random seeming) control functions for circuitry that
is off chip and only somewhat standard.

Jonathan