linux-kernel - Re: [RFC PATCH 3/4] iio: adc: Add support for AD4170

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241219141521.4617323a@jic23-huawei>
Date: Thu, 19 Dec 2024 14:15:21 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Marcelo Schmitt <marcelo.schmitt@...log.com>, linux-iio@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, Ana-Maria Cusco
 <ana-maria.cusco@...log.com>, lars@...afoo.de,
 Michael.Hennerich@...log.com, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, marcelo.schmitt1@...il.com, Dragos Bogdan
 <dragos.bogdan@...log.com>
Subject: Re: [RFC PATCH 3/4] iio: adc: Add support for AD4170

On Thu, 19 Dec 2024 10:25:42 +0100
Krzysztof Kozlowski <krzk@...nel.org> wrote:

> On Wed, Dec 18, 2024 at 11:37:59AM -0300, Marcelo Schmitt wrote:
> > +#include <asm/div64.h>
> > +#include <linux/unaligned.h>
> > +
> > +#include <linux/iio/buffer.h>
> > +#include <linux/iio/iio.h>
> > +#include <linux/iio/kfifo_buf.h>
> > +#include <linux/iio/sysfs.h>
> > +#include <linux/iio/trigger.h>
> > +#include <linux/iio/triggered_buffer.h>
> > +#include <linux/iio/trigger_consumer.h>
> > +#include "ad4170.h"
> > +  
> 
> No bindings header included? No usage of binding defines (I did look for
> them in case you have some incorrect include via other header)? So not a
> binding...

It's in the local header in this patch.

> diff --git a/drivers/iio/adc/ad4170.h b/drivers/iio/adc/ad4170.h
> new file mode 100644
> index 000000000000..5b24788314b1
> --- /dev/null
> +++ b/drivers/iio/adc/ad4170.h
> @@ -0,0 +1,316 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * AD4170 ADC driver
> + *
> + * Copyright 2024 Analog Devices Inc.
> + */
> +
> +#include <dt-bindings/iio/adc/adi,ad4170.h>

Agreed on the lack of them being used as widely as they should be though!

> 
> Best regards,
> Krzysztof
>