linux-kernel - Re: [PATCH] hwmon: pmbus: dps920ab: Add ability to instantiate through i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0f584d88-6264-4f7f-9600-0ebe8c0b8c64@roeck-us.net>
Date: Thu, 19 Dec 2024 06:15:49 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Denis Kirjanov <kirjanov@...il.com>, robert.marko@...tura.hr,
 jdelvare@...e.com
Cc: linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hwmon: pmbus: dps920ab: Add ability to instantiate
 through i2c

On 12/19/24 01:47, Denis Kirjanov wrote:
> Now we can bind the driver with a command like:
> 
> echo "dps920ab" 0x58 > /sys/bus/i2c/devices/i2c-0/new_device
> ...
> [616189.076211] i2c i2c-0: new_device: Instantiated device dps920ab at 0x58
> 

This is not an appropriate patch description.
Please refer to Documentation/process/submitting-patches.rst.

Thanks,
Guenter

> Signed-off-by: Denis Kirjanov <kirjanov@...il.com>
> ---
>   drivers/hwmon/pmbus/dps920ab.c | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/hwmon/pmbus/dps920ab.c b/drivers/hwmon/pmbus/dps920ab.c
> index cc5aac9dfdb3..c002ed41f517 100644
> --- a/drivers/hwmon/pmbus/dps920ab.c
> +++ b/drivers/hwmon/pmbus/dps920ab.c
> @@ -190,12 +190,19 @@ static const struct of_device_id __maybe_unused dps920ab_of_match[] = {
>   
>   MODULE_DEVICE_TABLE(of, dps920ab_of_match);
>   
> +static struct i2c_device_id dps920ab_i2c_match[] = {
> +	{ "dps920ab" },
> +	{}
> +};
> +MODULE_DEVICE_TABLE(i2c, dps920ab_i2c_match);
> +
>   static struct i2c_driver dps920ab_driver = {
>   	.driver = {
>   		   .name = "dps920ab",
>   		   .of_match_table = of_match_ptr(dps920ab_of_match),
>   	},
>   	.probe = dps920ab_probe,
> +	.id_table = dps920ab_device_id,
>   };
>   
>   module_i2c_driver(dps920ab_driver);