linux-kernel - Re: [PATCH 1/2] AutoFDO: Remove the architecture specific config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241219155239.GB24724@willie-the-truck>
Date: Thu, 19 Dec 2024 15:52:39 +0000
From: Will Deacon <will@...nel.org>
To: Rong Xu <xur@...gle.com>
Cc: Masahiro Yamada <masahiroy@...nel.org>, Yabin Cui <yabinc@...gle.com>,
	Han Shen <shenhan@...gle.com>, Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
	Dave Hansen <dave.hansen@...ux.intel.com>,
	"H. Peter Anvin" <hpa@...or.com>, Kees Cook <kees@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Sami Tolvanen <samitolvanen@...gle.com>,
	Alice Ryhl <aliceryhl@...gle.com>,
	"Mike Rapoport (Microsoft)" <rppt@...nel.org>,
	Samuel Holland <samuel.holland@...ive.com>,
	"Paul E. McKenney" <paulmck@...nel.org>,
	Arnd Bergmann <arnd@...db.de>, x86@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] AutoFDO: Remove the architecture specific config

On Wed, Dec 11, 2024 at 02:29:42PM -0800, Rong Xu wrote:
> The CONFIG_AUTOFDO_CLANG option currently depends on
> ARCH_SUPPORTS_AUTOFDO_CLANG, but this dependency seems unnecessary.
> 
> Remove ARCH_SUPPORTS_AUTOFDO_CLANG and allow users to control AutoFDO
> builds solely through CONFIG_AUTOFDO_CLANG. This simplifies the kconfig
> and avoids potential confusion.
> 
> Signed-off-by: Rong Xu <xur@...gle.com>
> Suggested-by: Will Deacon <will@...nel.org>
> ---
>  arch/Kconfig     | 4 ----
>  arch/x86/Kconfig | 1 -
>  2 files changed, 5 deletions(-)

Acked-by: Will Deacon <will@...nel.org>

However, you've dropped the previous hunk you had to
Documentation/dev-tools/autofdo.rst which had some text about using ETM
to collect fdo data on arm64. It seems like that might still be useful
to have?

Will