linux-kernel - Re: [PATCH V4] scsi: ufs: qcom: Enable UFS Shared ICE Feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a6eb14c7-84cd-41da-a24a-f0310738eb2f@acm.org>
Date: Fri, 20 Dec 2024 09:16:49 -0800
From: Bart Van Assche <bvanassche@....org>
To: Ram Kumar Dwivedi <quic_rdwivedi@...cinc.com>,
 manivannan.sadhasivam@...aro.org, James.Bottomley@...senPartnership.com,
 martin.petersen@...cle.com, andersson@...nel.org
Cc: linux-arm-msm@...r.kernel.org, linux-scsi@...r.kernel.org,
 linux-kernel@...r.kernel.org,
 Naveen Kumar Goud Arepalli <quic_narepall@...cinc.com>,
 Nitin Rawat <quic_nitirawa@...cinc.com>
Subject: Re: [PATCH V4] scsi: ufs: qcom: Enable UFS Shared ICE Feature

On 12/20/24 2:06 AM, Ram Kumar Dwivedi wrote:
> This function will be only called once during boot and "val" is a local variable, we don't see any advantage in making it static.
> If you still recommend, i will add the static keyword in next patchset.

The advantage of declaring the array static is that the array will be
initialized at compile time instead of at runtime. Additionally, this
will reduce stack utilization (assuming that the compiler does not
optimize out the array entirely).

Thanks,

Bart.