linux-kernel - Re: [PATCH V4] scsi: ufs: qcom: Enable UFS Shared ICE Feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <24e5e463-0ba2-4bca-a586-80e1d67cef05@quicinc.com>
Date: Mon, 23 Dec 2024 19:00:55 +0530
From: Ram Kumar Dwivedi <quic_rdwivedi@...cinc.com>
To: Bart Van Assche <bvanassche@....org>, <manivannan.sadhasivam@...aro.org>,
        <James.Bottomley@...senPartnership.com>, <martin.petersen@...cle.com>,
        <andersson@...nel.org>
CC: <linux-arm-msm@...r.kernel.org>, <linux-scsi@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        Naveen Kumar Goud Arepalli
	<quic_narepall@...cinc.com>,
        Nitin Rawat <quic_nitirawa@...cinc.com>
Subject: Re: [PATCH V4] scsi: ufs: qcom: Enable UFS Shared ICE Feature



On 20-Dec-24 10:46 PM, Bart Van Assche wrote:
> On 12/20/24 2:06 AM, Ram Kumar Dwivedi wrote:
>> This function will be only called once during boot and "val" is a local variable, we don't see any advantage in making it static.
>> If you still recommend, i will add the static keyword in next patchset.
> 
> The advantage of declaring the array static is that the array will be
> initialized at compile time instead of at runtime. Additionally, this
> will reduce stack utilization (assuming that the compiler does not
> optimize out the array entirely).
> 
Hi Bart,

We have added "static" keyword in latest patch set.

Thanks,
Ram.

> Thanks,
> 
> Bart.
>