linux-kernel - Re: [PATCH v3 1/3] drivers: base: Don't match devices with NULL of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2024122056-catnap-purist-a866@gregkh>
Date: Fri, 20 Dec 2024 18:44:05 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Shuah Khan <skhan@...uxfoundation.org>
Cc: David Gow <davidgow@...gle.com>,
	Brian Norris <briannorris@...omium.org>,
	Maxime Ripard <mripard@...nel.org>, linux-acpi@...r.kernel.org,
	Rae Moar <rmoar@...gle.com>, Rob Herring <robh@...nel.org>,
	linux-kselftest@...r.kernel.org,
	"Rafael J. Wysocki" <rafael@...nel.org>, kunit-dev@...glegroups.com,
	linux-kernel@...r.kernel.org,
	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>
Subject: Re: [PATCH v3 1/3] drivers: base: Don't match devices with NULL
 of_node/fwnode/etc

On Fri, Dec 20, 2024 at 10:33:51AM -0700, Shuah Khan wrote:
> On 12/18/24 22:45, David Gow wrote:
> > On Tue, 17 Dec 2024 at 04:12, Brian Norris <briannorris@...omium.org> wrote:
> > > 
> > > of_find_device_by_node(), bus_find_device_by_of_node(),
> > > bus_find_device_by_fwnode(), ..., all produce arbitrary results when
> > > provided with a NULL of_node, fwnode, ACPI handle, etc. This is
> > > counterintuitive, and the source of a few bugs, such as the one fixed by
> > > commit 5c8418cf4025 ("PCI/pwrctrl: Unregister platform device only if
> > > one actually exists").
> > > 
> > > It's hard to imagine a good reason that these device_match_*() APIs
> > > should return 'true' for a NULL argument. Augment these to return 0
> > > (false).
> > > 
> > > Reviewed-by: Rob Herring (Arm) <robh@...nel.org>
> > > Acked-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> > > Signed-off-by: Brian Norris <briannorris@...omium.org>
> > > ---
> > 
> > Seems sensible enough to me.
> > 
> > Acked-by: David Gow <davidgow@...gle.com>
> > 
> > I assume this series (including the KUnit test changes) will go in via Greg.
> > 
> 
> Works for me.
> 
> Acked-by: Shuah Khan <skhan@...uxfoundation.org>

Thanks, I'll take these in a few days.

greg k-h