linux-kernel - Re: [PATCH v2 1/1] lib: Remove dead code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024122052-laurel-showbiz-4d7b@gregkh>
Date: Fri, 20 Dec 2024 09:53:07 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Ariel Otilibili-Anieli <Ariel.Otilibili-Anieli@...ecom.fr>
Cc: linux-kernel@...r.kernel.org, Jan Beulich <jbeulich@...e.com>,
	stable@...r.kernel.org, Andrew Morton <akpm@...ux-foundation.org>,
	Andrew Cooper <andrew.cooper3@...rix.com>,
	Anthony PERARD <anthony.perard@...es.tech>,
	Michal Orzel <michal.orzel@....com>, Julien Grall <julien@....org>,
	Roger Pau Monné <roger.pau@...rix.com>,
	Stefano Stabellini <sstabellini@...nel.org>,
	xen-devel@...ts.xenproject.org
Subject: Re: [PATCH v2 1/1] lib: Remove dead code

On Fri, Dec 20, 2024 at 09:44:31AM +0100, Ariel Otilibili-Anieli wrote:
> On Friday, December 20, 2024 08:09 CET, Greg KH <gregkh@...uxfoundation.org> wrote:
> 
> > On Thu, Dec 19, 2024 at 11:45:01PM +0100, Ariel Otilibili wrote:
> > > This is a follow up from a discussion in Xen:
> > > 
> > > The if-statement tests `res` is non-zero; meaning the case zero is never reached.
> > > 
> > > Link: https://lore.kernel.org/all/7587b503-b2ca-4476-8dc9-e9683d4ca5f0@suse.com/
> > > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> > > Suggested-by: Jan Beulich <jbeulich@...e.com>
> > > Signed-off-by: Ariel Otilibili <ariel.otilibili-anieli@...ecom.fr>
> > > --
> > > Cc: stable@...r.kernel.org
> > 
> > Why is "removing dead code" a stable kernel thing?
> 
> Hello Greg,
> 
> It is what I understood from the process:
> 
> "Attaching a Fixes: tag does not subvert the stable kernel rules process nor the requirement to Cc: stable@...r.kernel.org on all stable patch candidates." [1]
> 
> Does my understanding make sense?

I'm confused, what are you expecting to happen here?  Why is this even
marked as a "fix"?

> [1] https://docs.kernel.org/process/submitting-patches.html

Please read:
    https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html

for the stable kernel rules.

Again, you have a "cc: stable@..." in your patch, why?

thanks,

greg k-h