linux-kernel - Re: [PATCH v2 1/1] lib: Remove dead code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2f7a89-67653a80-c09b-70827e80@197000382>
Date: Fri, 20 Dec 2024 10:36:53 +0100
From: "Ariel Otilibili-Anieli" <Ariel.Otilibili-Anieli@...ecom.fr>
To: "Greg KH" <gregkh@...uxfoundation.org>
Cc: linux-kernel@...r.kernel.org, "Jan Beulich" <jbeulich@...e.com>, "Andrew Morton" <akpm@...ux-foundation.org>, "Andrew Cooper" <andrew.cooper3@...rix.com>, "Anthony PERARD" <anthony.perard@...es.tech>, "Michal Orzel" <michal.orzel@....com>, "Julien Grall" <julien@....org>, Roger Pau Monné <roger.pau@...rix.com>, "Stefano Stabellini" <sstabellini@...nel.org>, xen-devel@...ts.xenproject.org
Subject: Re: [PATCH v2 1/1] lib: Remove dead code

On Friday, December 20, 2024 10:01 CET, "Ariel Otilibili-Anieli" <Ariel.Otilibili-Anieli@...ecom.fr> wrote:

> On Friday, December 20, 2024 09:53 CET, Greg KH <gregkh@...uxfoundation.org> wrote:
> 
> > On Fri, Dec 20, 2024 at 09:44:31AM +0100, Ariel Otilibili-Anieli wrote:
> > > On Friday, December 20, 2024 08:09 CET, Greg KH <gregkh@...uxfoundation.org> wrote:
> > > 
> > > > On Thu, Dec 19, 2024 at 11:45:01PM +0100, Ariel Otilibili wrote:
> > > > > This is a follow up from a discussion in Xen:
> > > > > 
> > > > > The if-statement tests `res` is non-zero; meaning the case zero is never reached.
> > > > > 
> > > > > Link: https://lore.kernel.org/all/7587b503-b2ca-4476-8dc9-e9683d4ca5f0@suse.com/
> > > > > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> > > > > Suggested-by: Jan Beulich <jbeulich@...e.com>
> > > > > Signed-off-by: Ariel Otilibili <ariel.otilibili-anieli@...ecom.fr>
> > > > > --
> > > > > Cc: stable@...r.kernel.org
> > > > 
> > > > Why is "removing dead code" a stable kernel thing?
> > > 
> > > Hello Greg,
> > > 
> > > It is what I understood from the process:
> > > 
> > > "Attaching a Fixes: tag does not subvert the stable kernel rules process nor the requirement to Cc: stable@...r.kernel.org on all stable patch candidates." [1]
> > > 
> > > Does my understanding make sense?
> > 
> > I'm confused, what are you expecting to happen here?  Why is this even
> > marked as a "fix"?

My understanding was that, for one-liners, the reference commit should be included; and CC stable.
> > 
> > > [1] https://docs.kernel.org/process/submitting-patches.html
> > 
> > Please read:
> >     https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
> 
> I am, Greg; thanks for the heads up.

Now I got the procedure; thank you.
> > 
> > for the stable kernel rules.
> > 
> > Again, you have a "cc: stable@..." in your patch, why?
> 
> Removed stable from the thread.

Hello again, Greg;

I should have said it upfront, for us to understand one another.
I have just checked, this thread is about v2 of the patch (with stable in CC); and v1 (without) was already accepted by  Andrew Morton [1].

If anything else I need to do, let me know.

Have a good day,
Ariel

[1] https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/lib-remove-dead-code.patch
> > 
> > thanks,
> > 
> > greg k-h