linux-kernel - Re: [PATCH v2 2/2] riscv: signal: fix signal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFTtA3M0uS+j9W0p78_iwSUVjh0BiV2bdp8ByT4f7pHah3QNeg@mail.gmail.com>
Date: Fri, 20 Dec 2024 22:48:57 +0800
From: Andy Chiu <andybnac@...il.com>
To: Yong-Xuan Wang <yongxuan.wang@...ive.com>
Cc: linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org, 
	greentime.hu@...ive.com, vincent.chen@...ive.com, zong.li@...ive.com, 
	Paul Walmsley <paul.walmsley@...ive.com>, Palmer Dabbelt <palmer@...belt.com>, 
	Albert Ou <aou@...s.berkeley.edu>, Haibo Xu <haibo1.xu@...el.com>, 
	Conor Dooley <conor.dooley@...rochip.com>, Usama Arif <usamaarif642@...il.com>, 
	Hanjun Guo <guohanjun@...wei.com>, Samuel Holland <samuel.holland@...ive.com>, 
	Alexandre Ghiti <alexghiti@...osinc.com>, Heiko Stuebner <heiko@...ech.de>, 
	Björn Töpel <bjorn@...osinc.com>
Subject: Re: [PATCH v2 2/2] riscv: signal: fix signal_minsigstksz

Hi Yong-Xuan,

Yong-Xuan Wang <yongxuan.wang@...ive.com> 於 2024年12月20日 週五 下午4:39寫道：
>
> The init_rt_signal_env() funciton is called before the alternative patch
> is applied, so using the alternative-related API to check the availability
> of an extension within this function doesn't have the intended effect.
> This patch reorders the init_rt_signal_env() and apply_boot_alternatives()
> to get the correct signal_minsigstksz.
>
> Fixes: e92f469b0771 ("riscv: signal: Report signal frame size to userspace via auxv")
> Signed-off-by: Yong-Xuan Wang <yongxuan.wang@...ive.com>
> Reviewed-by: Zong Li <zong.li@...ive.com>

Reviewed-by: Andy Chiu <andybnac@...il.com>

> ---
>  arch/riscv/kernel/setup.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/kernel/setup.c b/arch/riscv/kernel/setup.c
> index 016b48fcd6f2..b7c91f546453 100644
> --- a/arch/riscv/kernel/setup.c
> +++ b/arch/riscv/kernel/setup.c
> @@ -324,8 +324,8 @@ void __init setup_arch(char **cmdline_p)
>
>         riscv_init_cbo_blocksizes();
>         riscv_fill_hwcap();
> -       init_rt_signal_env();
>         apply_boot_alternatives();
> +       init_rt_signal_env();
>
>         if (IS_ENABLED(CONFIG_RISCV_ISA_ZICBOM) &&
>             riscv_isa_extension_available(NULL, ZICBOM))
> --
> 2.17.1
>

Thanks,
Andy