linux-kernel - Re: [PATCH v2 1/2] riscv: signal: fix signal frame size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f48321fd-e618-4d68-9fb4-5c6b4bf697b6@ghiti.fr>
Date: Mon, 6 Jan 2025 15:00:26 +0100
From: Alexandre Ghiti <alex@...ti.fr>
To: Yong-Xuan Wang <yongxuan.wang@...ive.com>, linux-kernel@...r.kernel.org,
 linux-riscv@...ts.infradead.org
Cc: greentime.hu@...ive.com, vincent.chen@...ive.com, AndybnAC@...il.com,
 zong.li@...ive.com, Paul Walmsley <paul.walmsley@...ive.com>,
 Palmer Dabbelt <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>,
 Conor Dooley <conor.dooley@...rochip.com>,
 Zhongqiu Han <quic_zhonhan@...cinc.com>,
 Bjorn Andersson <quic_bjorande@...cinc.com>, Björn Töpel
 <bjorn@...osinc.com>, Ben Dooks <ben.dooks@...ethink.co.uk>,
 Heiko Stuebner <heiko@...ech.de>
Subject: Re: [PATCH v2 1/2] riscv: signal: fix signal frame size

Hi Yong-Xuan,

On 20/12/2024 09:39, Yong-Xuan Wang wrote:
> The signal context of certain RISC-V extensions will be appended after
> struct __riscv_extra_ext_header, which already includes an empty context
> header. Therefore, there is no need to preserve a separate hdr for the
> END of signal context.
>
> Fixes: 8ee0b41898fa ("riscv: signal: Add sigcontext save/restore for vector")
> Signed-off-by: Yong-Xuan Wang <yongxuan.wang@...ive.com>
> Reviewed-by: Zong Li <zong.li@...ive.com>
> Reviewed-by: Andy Chiu <AndybnAC@...il.com>
> ---
>   arch/riscv/kernel/signal.c | 6 ------
>   1 file changed, 6 deletions(-)
>
> diff --git a/arch/riscv/kernel/signal.c b/arch/riscv/kernel/signal.c
> index dcd282419456..c3c517b9eee5 100644
> --- a/arch/riscv/kernel/signal.c
> +++ b/arch/riscv/kernel/signal.c
> @@ -215,12 +215,6 @@ static size_t get_rt_frame_size(bool cal_all)
>   		if (cal_all || riscv_v_vstate_query(task_pt_regs(current)))
>   			total_context_size += riscv_v_sc_size;
>   	}
> -	/*
> -	 * Preserved a __riscv_ctx_hdr for END signal context header if an
> -	 * extension uses __riscv_extra_ext_header
> -	 */
> -	if (total_context_size)
> -		total_context_size += sizeof(struct __riscv_ctx_hdr);
>   
>   	frame_size += total_context_size;
>   


Reviewed-by: Alexandre Ghiti <alexghiti@...osinc.com>

Thanks,

Alex