linux-kernel - Re: [PATCH 12/16] dt-bindings: media: camss: Add qcom,sm8550-camss binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a0eafc67-2ebf-4d2a-8213-c30c3c317a1a@xs4all.nl>
Date: Mon, 6 Jan 2025 15:00:52 +0100
From: Hans Verkuil <hverkuil@...all.nl>
To: Depeng Shao <quic_depengs@...cinc.com>,
 Krzysztof Kozlowski <krzk@...nel.org>
Cc: rfoss@...nel.org, todor.too@...il.com, bryan.odonoghue@...aro.org,
 mchehab@...nel.org, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, vladimir.zapolskiy@...aro.org,
 quic_eberman@...cinc.com, linux-media@...r.kernel.org,
 linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, kernel@...cinc.com,
 Yongsheng Li <quic_yon@...cinc.com>
Subject: Re: [PATCH 12/16] dt-bindings: media: camss: Add qcom,sm8550-camss
 binding

On 04/01/2025 14:40, Depeng Shao wrote:
> Hi Krzysztof,
> 
> On 12/27/2024 5:10 PM, Krzysztof Kozlowski wrote:
>> On Wed, Dec 25, 2024 at 07:05:19PM +0530, Depeng Shao wrote:
>>> Add bindings for qcom,sm8550-camss in order to support the camera
>>> subsystem for sm8550.
>>>
>>> Co-developed-by: Yongsheng Li <quic_yon@...cinc.com>
>>> Signed-off-by: Yongsheng Li <quic_yon@...cinc.com>
>>> Signed-off-by: Depeng Shao <quic_depengs@...cinc.com>
>>> ---
>>
>> Is this v7 or v1? Same issue was all the time in the past, so why can't
>> you finally fix it?
>>
>> Look:
>>
>> $ b4 diff 20241225133523.4034820-13-quic_depengs@...cinc.com
>> Breaking thread to remove parents of 20241225133523.4034820-1-quic_depengs@...cinc.com
>> Checking for older revisions
>> Grabbing search results from lore.kernel.org
>>    Added from v6: 1 patches
>> ---
>> Analyzing 217 messages in the thread
>> Could not find lower series to compare against.
>>
>> I am not going to perform review, maybe other maintaners have spare
>> time to deal with this submission process.
> 
> Really sorry, I made a foolish mistake. I didn't realize that the patch 
> subject was missing the version number, which might be why the b4 diff 
> couldn't detect the old series. Thank you for pointing out this error. 
> Could you please advise whether I should resend v7 or fix it in next 
> version series?

I marked this series as 'Changes Requested' in our media patchwork because
of this issue.

So resend it as v8 with the proper [PATCH v8 ...] subject.

It's a nightmare for maintainers/reviewers if it isn't clear if a patch series
supersedes a previous series, so it is important that you do this right.

Regards,

	Hans

> 
> I have also found a workaround to replace "b4 diff". Last time, you 
> helped by giving a RB tag on the version 4 dt-binding. You can check the 
> differences[1] between version 4 and version 7 on the Patchew website. 
> If possible, could you please help review the diff provided by Patchew 
> once again? Sorry for wasting your time.
> 
> Visit below website[1], then search "dt-bindings: media: camss: Add 
> qcom,sm8550-camss binding", then we can get the difference between 
> version4 and version7.
> 
> 
> [1] 
> https://patchew.org/linux/20240812144131.369378-1-quic._5Fdepengs@quicinc.com/diff/20241225133523.4034820-1-quic._5Fdepengs@quicinc.com/
> 
> 
> Thanks,
> Depeng
>