linux-kernel - Re: [PATCH v21 03/20] fgraph: Replace fgraph_ret_regs with ftrace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241220100856.1a436ad3@gandalf.local.home>
Date: Fri, 20 Dec 2024 10:08:56 -0500
From: Steven Rostedt <rostedt@...dmis.org>
To: Heiko Carstens <hca@...ux.ibm.com>
Cc: "Masami Hiramatsu (Google)" <mhiramat@...nel.org>, Alexei Starovoitov
 <alexei.starovoitov@...il.com>, Florent Revest <revest@...omium.org>,
 linux-trace-kernel@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
 Martin KaFai Lau <martin.lau@...ux.dev>, bpf <bpf@...r.kernel.org>, Alexei
 Starovoitov <ast@...nel.org>, Jiri Olsa <jolsa@...nel.org>, Alan Maguire
 <alan.maguire@...cle.com>, Mark Rutland <mark.rutland@....com>,
 linux-arch@...r.kernel.org, Will Deacon <will@...nel.org>, Catalin Marinas
 <catalin.marinas@....com>, Huacai Chen <chenhuacai@...nel.org>, WANG Xuerui
 <kernel@...0n.name>, Paul Walmsley <paul.walmsley@...ive.com>, Palmer
 Dabbelt <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>, Vasily
 Gorbik <gor@...ux.ibm.com>, Alexander Gordeev <agordeev@...ux.ibm.com>,
 Christian Borntraeger <borntraeger@...ux.ibm.com>, Sven Schnelle
 <svens@...ux.ibm.com>, Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar
 <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>, Dave Hansen
 <dave.hansen@...ux.intel.com>, x86@...nel.org, "H. Peter Anvin"
 <hpa@...or.com>, Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
Subject: Re: [PATCH v21 03/20] fgraph: Replace fgraph_ret_regs with
 ftrace_regs

On Fri, 20 Dec 2024 15:51:56 +0100
Heiko Carstens <hca@...ux.ibm.com> wrote:

> On Thu, Dec 19, 2024 at 04:34:48PM -0500, Steven Rostedt wrote:
> > On Tue, 10 Dec 2024 11:09:26 +0900
> > "Masami Hiramatsu (Google)" <mhiramat@...nel.org> wrote:
> >   
> > > From: Masami Hiramatsu (Google) <mhiramat@...nel.org>
> > > 
> > > Use ftrace_regs instead of fgraph_ret_regs for tracing return value
> > > on function_graph tracer because of simplifying the callback interface.
> > > 
> > > The CONFIG_HAVE_FUNCTION_GRAPH_RETVAL is also replaced by
> > > CONFIG_HAVE_FUNCTION_GRAPH_FREGS.
> > > 
> > > Signed-off-by: Masami Hiramatsu (Google) <mhiramat@...nel.org>
> > > Acked-by: Heiko Carstens <hca@...ux.ibm.com>  
> > 
> > Did Heiko ack this? I don't see it in my inbox.  
> 
> Yes, I did:
> https://lore.kernel.org/lkml/20240916121656.20933-B-hca@linux.ibm.com/

Oh OK. I didn't go back that far as it appeared you questioned this patch
in v16:

  https://lore.kernel.org/all/20241016083323.16801-A-hca@linux.ibm.com/

> 
> > Heiko,
> > 
> > Does the above look OK to you?  
> 
> Looks still good to me.

Thanks, I'll likely pull in the series after rc4 and get it ready for
linux-next.

-- Steve