linux-kernel - Re: [PATCH v2 5/7] dt-bindings: arm: rockchip: Sort for rk3568 evb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <D6GMFFSALGMQ.3GQ1PUD6L2TV8@cknow.org>
Date: Fri, 20 Dec 2024 16:08:54 +0100
From: "Diederik de Haas" <didi.debian@...ow.org>
To: "Kever Yang" <kever.yang@...k-chips.com>, <heiko@...ech.de>
Cc: <linux-rockchip@...ts.infradead.org>, "Conor Dooley"
 <conor.dooley@...rochip.com>, <devicetree@...r.kernel.org>, "Conor Dooley"
 <conor+dt@...nel.org>, "Chris Morgan" <macromorgan@...mail.com>, "Rob
 Herring" <robh@...nel.org>, "Dragan Simic" <dsimic@...jaro.org>, "Jonas
 Karlman" <jonas@...boo.se>, <linux-kernel@...r.kernel.org>, "Tim Lunn"
 <tim@...thertop.org>, <linux-arm-kernel@...ts.infradead.org>, "Krzysztof
 Kozlowski" <krzk+dt@...nel.org>, "Jianfeng Liu"
 <liujianfeng1994@...il.com>, "Andy Yan" <andyshrk@....com>
Subject: Re: [PATCH v2 5/7] dt-bindings: arm: rockchip: Sort for rk3568 evb

Hi Kever,

On Fri Dec 20, 2024 at 11:15 AM CET, Kever Yang wrote:
> The info for rk3568 should before rk3588.

Indeed, so thanks for this patch.

> Signed-off-by: Kever Yang <kever.yang@...k-chips.com>
> Acked-by: Conor Dooley <conor.dooley@...rochip.com>
> ---
>
> Changes in v2:
> - collect acked-by tag
>
>  .../devicetree/bindings/arm/rockchip.yaml     | 20 +++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 753199a12923..45ee4bf7c80c 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -1006,6 +1006,16 @@ properties:
>            - const: rockchip,rk3399-sapphire-excavator
>            - const: rockchip,rk3399
>  
> +      - description: Rockchip RK3566 BOX Evaluation Demo board
> +        items:
> +          - const: rockchip,rk3566-box-demo
> +          - const: rockchip,rk3566
> +
> +      - description: Rockchip RK3568 Evaluation board
> +        items:
> +          - const: rockchip,rk3568-evb1-v10
> +          - const: rockchip,rk3568
> +
>        - description: Rockchip RK3588 Evaluation board
>          items:
>            - const: rockchip,rk3588-evb1-v10
> @@ -1099,16 +1109,6 @@ properties:
>            - const: zkmagic,a95x-z2
>            - const: rockchip,rk3318
>  
> -      - description: Rockchip RK3566 BOX Evaluation Demo board
> -        items:
> -          - const: rockchip,rk3566-box-demo
> -          - const: rockchip,rk3566
> -
> -      - description: Rockchip RK3568 Evaluation board
> -        items:
> -          - const: rockchip,rk3568-evb1-v10
> -          - const: rockchip,rk3568
> -

While you're fixing the sorting order of these 2 Rockchip items, it
would be great if "Sinovoip RK3308 Banana Pi P2 Pro", "Sinovoip RK3568
Banana Pi R2 Pro" and "Sonoff iHost Smart Home Hub" could also be moved
into their correctly sorted position. A quick scan seems to indicate
that all the other items are properly sorted.

Cheers,
  Diederik

>        - description: Sinovoip RK3308 Banana Pi P2 Pro
>          items:
>            - const: sinovoip,rk3308-bpi-p2pro


Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)