linux-kernel - Re: [PATCH -next v5] mm: vmscan: retry folios written back while isolated for traditional LRU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202412211023.UIBZqNFK-lkp@intel.com>
Date: Sat, 21 Dec 2024 10:35:45 +0800
From: kernel test robot <lkp@...el.com>
To: Chen Ridong <chenridong@...weicloud.com>, akpm@...ux-foundation.org,
	mhocko@...e.com, hannes@...xchg.org, yosryahmed@...gle.com,
	yuzhao@...gle.com, david@...hat.com, willy@...radead.org,
	ryan.roberts@....com, baohua@...nel.org, 21cnbao@...il.com,
	wangkefeng.wang@...wei.com
Cc: oe-kbuild-all@...ts.linux.dev, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, chenridong@...wei.com,
	wangweiyang2@...wei.com, xieym_ict@...mail.com
Subject: Re: [PATCH -next v5] mm: vmscan: retry folios written back while
 isolated for traditional LRU

Hi Chen,

kernel test robot noticed the following build errors:

[auto build test ERROR on akpm-mm/mm-everything]

url:    https://github.com/intel-lab-lkp/linux/commits/Chen-Ridong/mm-vmscan-retry-folios-written-back-while-isolated-for-traditional-LRU/20241220-092147
base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link:    https://lore.kernel.org/r/20241220010931.3603111-1-chenridong%40huaweicloud.com
patch subject: [PATCH -next v5] mm: vmscan: retry folios written back while isolated for traditional LRU
config: i386-buildonly-randconfig-003-20241220 (https://download.01.org/0day-ci/archive/20241221/202412211023.UIBZqNFK-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241221/202412211023.UIBZqNFK-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412211023.UIBZqNFK-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from include/linux/migrate.h:8,
                    from mm/vmscan.c:42:
   include/linux/hugetlb.h:1063:5: warning: no previous prototype for 'replace_free_hugepage_folios' [-Wmissing-prototypes]
    1063 | int replace_free_hugepage_folios(unsigned long start_pfn, unsigned long end_pfn)
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
   mm/vmscan.c: In function 'find_folios_written_back':
>> mm/vmscan.c:313:43: error: implicit declaration of function 'lru_gen_distance'; did you mean 'node_distance'? [-Werror=implicit-function-declaration]
     313 |                 if (lru_gen_enabled() && !lru_gen_distance(folio, false))
         |                                           ^~~~~~~~~~~~~~~~
         |                                           node_distance
   cc1: some warnings being treated as errors


vim +313 mm/vmscan.c

   285	
   286	/**
   287	 * find_folios_written_back - Find and move the written back folios to a new list.
   288	 * @list: filios list
   289	 * @clean: the written back folios list
   290	 * @is_retried: whether the list has already been retried.
   291	 */
   292	static inline void find_folios_written_back(struct list_head *list,
   293			struct list_head *clean, bool is_retried)
   294	{
   295		struct folio *folio;
   296		struct folio *next;
   297	
   298		list_for_each_entry_safe_reverse(folio, next, list, lru) {
   299			if (!folio_evictable(folio)) {
   300				list_del(&folio->lru);
   301				folio_putback_lru(folio);
   302				continue;
   303			}
   304	
   305			/* retry folios that may have missed folio_rotate_reclaimable() */
   306			if (!is_retried && !folio_test_active(folio) && !folio_mapped(folio) &&
   307			    !folio_test_dirty(folio) && !folio_test_writeback(folio)) {
   308				list_move(&folio->lru, clean);
   309				continue;
   310			}
   311	
   312			/* don't add rejected folios to the oldest generation */
 > 313			if (lru_gen_enabled() && !lru_gen_distance(folio, false))
   314				set_mask_bits(&folio->flags, LRU_REFS_FLAGS, BIT(PG_active));
   315		}
   316	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki