linux-kernel - Re: [PATCH v16] pwm: opencores: Add PWM driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <52j6gtyzf4uwfkxxlfschygnvuwl2l4iaf7mzbi2nbzxtmlemf@dktywu73nldg>
Date: Mon, 23 Dec 2024 18:12:05 +0100
From: Uwe Kleine-König <ukleinek@...nel.org>
To: William Qiu <william.qiu@...rfivetech.com>
Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, 
	"linux-pwm@...r.kernel.org" <linux-pwm@...r.kernel.org>, Hal Feng <hal.feng@...rfivetech.com>, 
	Philipp Zabel <p.zabel@...gutronix.de>
Subject: Re: [PATCH v16] pwm: opencores: Add PWM driver support

Hello William,

On Mon, Dec 23, 2024 at 02:47:59AM +0000, William Qiu wrote:
> > > +	duty_data = mul_u64_u32_div(state->duty_cycle, ddata->clk_rate,
> > NSEC_PER_SEC);
> > > +	if (!duty_data)
> > > +		return -EINVAL;
> > 
> > I can understand that period_data == 0 is an error, but duty_data == 0
> > could/should just work?!
>
> It means no need to check whether the duty is valid? 

No, it means that I expect that duty_data == 0 is a valid setting and
most controllers support it.

Best regards
Uwe

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)