linux-kernel - Re: [PATCH] Update USB/IP OP_REP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <42623280-d7da-4bc9-98a5-65de33d4f6dc@linuxfoundation.org>
Date: Mon, 23 Dec 2024 10:11:11 -0700
From: Shuah Khan <skhan@...uxfoundation.org>
To: Gordon Ou <gordon.xwj@...il.com>,
 Valentina Manea <valentina.manea.m@...il.com>, Shuah Khan <shuah@...nel.org>
Cc: Hongren Zheng <i@...ithal.me>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Jonathan Corbet <corbet@....net>, linux-usb@...r.kernel.org,
 linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org, trivial@...nel.org,
 Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] Update USB/IP OP_REP_IMPORT documentation.

On 12/23/24 02:04, Gordon Ou wrote:
> Corrects byte offsets for OP_REP_IMPORT.

Add more information on why this change is needed.

> 
> Signed-off-by: Gordon Ou <gordon.xwj@...il.com>
> ---
>   Documentation/usb/usbip_protocol.rst | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/Documentation/usb/usbip_protocol.rst b/Documentation/usb/usbip_protocol.rst
> index adc158967cc6..3da1df3d94f5 100644
> --- a/Documentation/usb/usbip_protocol.rst
> +++ b/Documentation/usb/usbip_protocol.rst
> @@ -285,17 +285,17 @@ OP_REP_IMPORT:
>   +-----------+--------+------------+---------------------------------------------------+
>   | 0x138     | 2      |            | bcdDevice                                         |
>   +-----------+--------+------------+---------------------------------------------------+
> -| 0x139     | 1      |            | bDeviceClass                                      |
> +| 0x13A     | 1      |            | bDeviceClass                                      |
>   +-----------+--------+------------+---------------------------------------------------+
> -| 0x13A     | 1      |            | bDeviceSubClass                                   |
> +| 0x13B     | 1      |            | bDeviceSubClass                                   |
>   +-----------+--------+------------+---------------------------------------------------+
> -| 0x13B     | 1      |            | bDeviceProtocol                                   |
> +| 0x13C     | 1      |            | bDeviceProtocol                                   |
>   +-----------+--------+------------+---------------------------------------------------+
> -| 0x13C     | 1      |            | bConfigurationValue                               |
> +| 0x13D     | 1      |            | bConfigurationValue                               |
>   +-----------+--------+------------+---------------------------------------------------+
> -| 0x13D     | 1      |            | bNumConfigurations                                |
> +| 0x13E     | 1      |            | bNumConfigurations                                |
>   +-----------+--------+------------+---------------------------------------------------+
> -| 0x13E     | 1      |            | bNumInterfaces                                    |
> +| 0x13F     | 1      |            | bNumInterfaces                                    |
>   +-----------+--------+------------+---------------------------------------------------+
>   
>   The following four commands have a common basic header called

thanks,
-- Shuah