linux-kernel - Re: [PATCH] Update USB/IP OP_REP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD2T5m-kZAqeR3fSXHVDtevLkU0FynriwM+tb==eYaNXvVhb=g@mail.gmail.com>
Date: Tue, 24 Dec 2024 11:00:38 +0800
From: Gordon - <gordon.xwj@...il.com>
To: Shuah Khan <skhan@...uxfoundation.org>
Cc: Valentina Manea <valentina.manea.m@...il.com>, Shuah Khan <shuah@...nel.org>, 
	Hongren Zheng <i@...ithal.me>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	Jonathan Corbet <corbet@....net>, linux-usb@...r.kernel.org, linux-doc@...r.kernel.org, 
	linux-kernel@...r.kernel.org, trivial@...nel.org
Subject: Re: [PATCH] Update USB/IP OP_REP_IMPORT documentation.

On Tue, Dec 24, 2024 at 1:11 AM Shuah Khan <skhan@...uxfoundation.org> wrote:
>
> On 12/23/24 02:04, Gordon Ou wrote:
> > Corrects byte offsets for OP_REP_IMPORT.
>
> Add more information on why this change is needed.
>

The change is needed to correct the mistaken byte offset of the field
bDeviceClass in OP_REP_IMPORT documentation. The previous field bcdDevice
has length 2 and the offset for bDeviceClass should be 0x138 + 2 = 0x13A
instead of 0x139. Offsets for subsequent fields are also affected and fixed
in this patch.

> >
> > Signed-off-by: Gordon Ou <gordon.xwj@...il.com>
> > ---
> >   Documentation/usb/usbip_protocol.rst | 12 ++++++------
> >   1 file changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/Documentation/usb/usbip_protocol.rst b/Documentation/usb/usbip_protocol.rst
> > index adc158967cc6..3da1df3d94f5 100644
> > --- a/Documentation/usb/usbip_protocol.rst
> > +++ b/Documentation/usb/usbip_protocol.rst
> > @@ -285,17 +285,17 @@ OP_REP_IMPORT:
> >   +-----------+--------+------------+---------------------------------------------------+
> >   | 0x138     | 2      |            | bcdDevice                                         |
> >   +-----------+--------+------------+---------------------------------------------------+
> > -| 0x139     | 1      |            | bDeviceClass                                      |
> > +| 0x13A     | 1      |            | bDeviceClass                                      |
> >   +-----------+--------+------------+---------------------------------------------------+
> > -| 0x13A     | 1      |            | bDeviceSubClass                                   |
> > +| 0x13B     | 1      |            | bDeviceSubClass                                   |
> >   +-----------+--------+------------+---------------------------------------------------+
> > -| 0x13B     | 1      |            | bDeviceProtocol                                   |
> > +| 0x13C     | 1      |            | bDeviceProtocol                                   |
> >   +-----------+--------+------------+---------------------------------------------------+
> > -| 0x13C     | 1      |            | bConfigurationValue                               |
> > +| 0x13D     | 1      |            | bConfigurationValue                               |
> >   +-----------+--------+------------+---------------------------------------------------+
> > -| 0x13D     | 1      |            | bNumConfigurations                                |
> > +| 0x13E     | 1      |            | bNumConfigurations                                |
> >   +-----------+--------+------------+---------------------------------------------------+
> > -| 0x13E     | 1      |            | bNumInterfaces                                    |
> > +| 0x13F     | 1      |            | bNumInterfaces                                    |
> >   +-----------+--------+------------+---------------------------------------------------+
> >
> >   The following four commands have a common basic header called
>
> thanks,
> -- Shuah

Thanks for the reply, please find my update inline, and let me know if an
updated patch is needed.

Gordon