linux-kernel - Re: [PATCH] Update USB/IP OP_REP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2024122456-verse-giblet-9870@gregkh>
Date: Tue, 24 Dec 2024 06:52:10 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Gordon - <gordon.xwj@...il.com>
Cc: Shuah Khan <skhan@...uxfoundation.org>,
	Valentina Manea <valentina.manea.m@...il.com>,
	Shuah Khan <shuah@...nel.org>, Hongren Zheng <i@...ithal.me>,
	Jonathan Corbet <corbet@....net>, linux-usb@...r.kernel.org,
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
	trivial@...nel.org
Subject: Re: [PATCH] Update USB/IP OP_REP_IMPORT documentation.

On Tue, Dec 24, 2024 at 11:00:38AM +0800, Gordon - wrote:
> On Tue, Dec 24, 2024 at 1:11 AM Shuah Khan <skhan@...uxfoundation.org> wrote:
> >
> > On 12/23/24 02:04, Gordon Ou wrote:
> > > Corrects byte offsets for OP_REP_IMPORT.
> >
> > Add more information on why this change is needed.
> >
> 
> The change is needed to correct the mistaken byte offset of the field
> bDeviceClass in OP_REP_IMPORT documentation. The previous field bcdDevice
> has length 2 and the offset for bDeviceClass should be 0x138 + 2 = 0x13A
> instead of 0x139. Offsets for subsequent fields are also affected and fixed
> in this patch.

Great, please include that in the changelog text when you resend this.

thanks,

greg k-h