linux-kernel - Re: [PATCH V3 2/2] ASoC: codecs: Add aw88083 amplifier driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241224105655.271068f8@booty>
Date: Tue, 24 Dec 2024 10:56:55 +0100
From: Luca Ceresoli <luca.ceresoli@...tlin.com>
To: wangweidong.a@...nic.com
Cc: lgirdwood@...il.com, broonie@...nel.org, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, perex@...ex.cz, tiwai@...e.com,
 ivprusov@...utedevices.com, neil.armstrong@...aro.org, jack.yu@...ltek.com,
 rf@...nsource.cirrus.com, quic_pkumpatl@...cinc.com,
 herve.codina@...tlin.com, masahiroy@...nel.org, nuno.sa@...log.com,
 yesanishhere@...il.com, linux-sound@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 yijiangtao@...nic.com, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH V3 2/2] ASoC: codecs: Add aw88083 amplifier driver

Hello Weidong,

On Tue, 24 Dec 2024 11:18:23 +0800
wangweidong.a@...nic.com wrote:

> From: Weidong Wang <wangweidong.a@...nic.com>
> 
> The driver is for amplifiers aw88083 of Awinic Technology
> Corporation. The AW88083 is an intelligent digital audio
> amplifier with low noise.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202412201745.fBpf3Ui5-lkp@intel.com/

You should not add these two lines. From the kernel test robot report:

> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202412201745.fBpf3Ui5-lkp@intel.com/

If you think about someone looking at git log in the future, they will
see the final version of your patch, they will never see v2. So the
final version (v3, v4, whatever) is not fixing any error as the error in
v2 will never be applied.

Luca

-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com