[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20241224110916.373428-1-wangweidong.a@awinic.com>
Date: Tue, 24 Dec 2024 19:09:16 +0800
From: wangweidong.a@...nic.com
To: luca.ceresoli@...tlin.com
Cc: broonie@...nel.org,
conor+dt@...nel.org,
devicetree@...r.kernel.org,
herve.codina@...tlin.com,
ivprusov@...utedevices.com,
jack.yu@...ltek.com,
krzk+dt@...nel.org,
lgirdwood@...il.com,
linux-kernel@...r.kernel.org,
linux-sound@...r.kernel.org,
lkp@...el.com,
masahiroy@...nel.org,
neil.armstrong@...aro.org,
nuno.sa@...log.com,
perex@...ex.cz,
quic_pkumpatl@...cinc.com,
rf@...nsource.cirrus.com,
robh@...nel.org,
tiwai@...e.com,
wangweidong.a@...nic.com,
yesanishhere@...il.com,
yijiangtao@...nic.com
Subject: Re: [PATCH V3 2/2] ASoC: codecs: Add aw88083 amplifier driver
On Tue, 24 Dec 2024 10:56:55 +0100 luca.ceresoli@...tlin.com wrote:
> On Tue, 24 Dec 2024 11:18:23 +0800
> wangweidong.a@...nic.com wrote:
>> From: Weidong Wang <wangweidong.a@...nic.com>
>>
>> The driver is for amplifiers aw88083 of Awinic Technology
>> Corporation. The AW88083 is an intelligent digital audio
>> amplifier with low noise.
>>
>> Reported-by: kernel test robot <lkp@...el.com>
>> Closes: https://lore.kernel.org/oe-kbuild-all/202412201745.fBpf3Ui5-lkp@intel.com/
> You should not add these two lines. From the kernel test robot report:
>> If you fix the issue in a separate patch/commit (i.e. not just a new version of
>> the same patch/commit), kindly add following tags
>> | Reported-by: kernel test robot <lkp@...el.com>
>> | Closes: https://lore.kernel.org/oe-kbuild-all/202412201745.fBpf3Ui5-lkp@intel.com/
> If you think about someone looking at git log in the future, they will
> see the final version of your patch, they will never see v2. So the
> final version (v3, v4, whatever) is not fixing any error as the error in
> v2 will never be applied.
hi Luca,
Thank you very much for your review.
I will remove these two lines in PATCH V4
Best regards
Weidong Wang
Powered by blists - more mailing lists