linux-kernel - Re: [PATCH] dm: change kzalloc to kcalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d38e99d7-1f24-4c7b-87de-111c345b02cf@embeddedor.com>
Date: Tue, 24 Dec 2024 16:42:07 -0600
From: "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To: Ethan Carter Edwards <ethan@...ancedwards.com>,
 "agk@...hat.com" <agk@...hat.com>
Cc: "snitzer@...nel.org" <snitzer@...nel.org>,
 "dm-devel@...ts.linux.dev" <dm-devel@...ts.linux.dev>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "kernel-hardening@...ts.openwall.com" <kernel-hardening@...ts.openwall.com>,
 "linux-hardening@...r.kernel.org" <linux-hardening@...r.kernel.org>,
 "mpatocka@...hat.com" <mpatocka@...hat.com>
Subject: Re: [PATCH] dm: change kzalloc to kcalloc

On 24/12/24 16:13, Ethan Carter Edwards wrote:
> Use 2-factor multiplication argument form kcalloc() instead
> of instead of the deprecated kzalloc() [1].

Thanks for the patch - Just note that kzalloc() is by no means
deprecated.

> 
> [1] https://www.kernel.org/doc/html/next/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments
> Link: https://github.com/KSPP/linux/issues/162
> 
> Signed-off-by: Ethan Carter Edwards <ethan@...ancedwards.com>

Reviewed-by: Gustavo A. R. Silva <gustavoars@...nel.org>

-Gustavo

> ---
>   drivers/md/dm-ps-io-affinity.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/md/dm-ps-io-affinity.c b/drivers/md/dm-ps-io-affinity.c
> index 461ee6b2044d..716807e511ee 100644
> --- a/drivers/md/dm-ps-io-affinity.c
> +++ b/drivers/md/dm-ps-io-affinity.c
> @@ -116,7 +116,7 @@ static int ioa_create(struct path_selector *ps, unsigned int argc, char **argv)
>   	if (!s)
>   		return -ENOMEM;
>   
> -	s->path_map = kzalloc(nr_cpu_ids * sizeof(struct path_info *),
> +	s->path_map = kcalloc(nr_cpu_ids, sizeof(struct path_info *),
>   			     GFP_KERNEL);
>   	if (!s->path_map)
>   		goto free_selector;