lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <5nrjgp4drxgrqqu5e4yfnvnnnr34ffj4ielytmw2bvr5ewy7qe@bquvoxvxqmxg>
Date: Wed, 25 Dec 2024 23:26:35 -0600
From: Bjorn Andersson <andersson@...nel.org>
To: Mao Jinlong <quic_jinlmao@...cinc.com>
Cc: Suzuki K Poulose <suzuki.poulose@....com>, 
	Mike Leach <mike.leach@...aro.org>, James Clark <james.clark@....com>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Mathieu Poirier <mathieu.poirier@...aro.org>, Konrad Dybcio <konradybcio@...nel.org>, 
	coresight@...ts.linaro.org, linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH v5 2/2] arm64: dts: qcom: sm8450: Add coresight nodes

On Fri, Sep 27, 2024 at 02:54:11AM -0700, Mao Jinlong wrote:
> Add coresight components on Qualcomm SM8450 Soc. The components include
> TMC ETF/ETR, ETE, STM, TPDM, CTI.
> 
> Signed-off-by: Mao Jinlong <quic_jinlmao@...cinc.com>

Please rebase to fix the &CPUn vs &cpun issue, and please fix the
dtbs_check errors.

Thanks,
Bjorn

> ---
>  arch/arm64/boot/dts/qcom/sm8450.dtsi | 726 +++++++++++++++++++++++++++
>  1 file changed, 726 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> index 9bafb3b350ff..6d90d6045628 100644
> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> @@ -287,6 +287,192 @@ CLUSTER_SLEEP_1: cluster-sleep-1 {
>  		};
>  	};
>  
> +	ete-0 {
> +		compatible = "arm,embedded-trace-extension";
> +		cpu = <&CPU0>;
> +
> +		out-ports {
> +			port {
> +				ete0_out_funnel_ete: endpoint {
> +					remote-endpoint = <&funnel_ete_in_ete0>;
> +				};
> +			};
> +		};
> +	};
> +
> +	ete-1 {
> +		compatible = "arm,embedded-trace-extension";
> +		cpu = <&CPU1>;
> +
> +		out-ports {
> +			port {
> +				ete1_out_funnel_ete: endpoint {
> +					remote-endpoint = <&funnel_ete_in_ete1>;
> +				};
> +			};
> +		};
> +	};
> +
> +	ete-2 {
> +		compatible = "arm,embedded-trace-extension";
> +		cpu = <&CPU2>;
> +
> +		out-ports {
> +			port {
> +				ete2_out_funnel_ete: endpoint {
> +					remote-endpoint = <&funnel_ete_in_ete2>;
> +				};
> +			};
> +		};
> +	};
> +
> +	ete-3 {
> +		compatible = "arm,embedded-trace-extension";
> +		cpu = <&CPU3>;
> +
> +		out-ports {
> +			port {
> +				ete3_out_funnel_ete: endpoint {
> +					remote-endpoint = <&funnel_ete_in_ete3>;
> +				};
> +			};
> +		};
> +	};
> +
> +	ete-4 {
> +		compatible = "arm,embedded-trace-extension";
> +		cpu = <&CPU4>;
> +
> +		out-ports {
> +			port {
> +				ete4_out_funnel_ete: endpoint {
> +					remote-endpoint = <&funnel_ete_in_ete4>;
> +				};
> +			};
> +		};
> +	};
> +
> +	ete-5 {
> +		compatible = "arm,embedded-trace-extension";
> +		cpu = <&CPU5>;
> +
> +		out-ports {
> +			port {
> +				ete5_out_funnel_ete: endpoint {
> +					remote-endpoint = <&funnel_ete_in_ete5>;
> +				};
> +			};
> +		};
> +	};
> +
> +	ete-6 {
> +		compatible = "arm,embedded-trace-extension";
> +		cpu = <&CPU6>;
> +
> +		out-ports {
> +			port {
> +				ete6_out_funnel_ete: endpoint {
> +					remote-endpoint = <&funnel_ete_in_ete6>;
> +				};
> +			};
> +		};
> +	};
> +
> +	ete-7 {
> +		compatible = "arm,embedded-trace-extension";
> +		cpu = <&CPU7>;
> +
> +		out-ports {
> +			port {
> +				ete7_out_funnel_ete: endpoint {
> +					remote-endpoint = <&funnel_ete_in_ete7>;
> +				};
> +			};
> +		};
> +	};
> +
> +	funnel-ete {
> +		compatible = "arm,coresight-static-funnel";
> +
> +		out-ports {
> +			port {
> +				funnel_ete_out_funnel_apss: endpoint {
> +					remote-endpoint =
> +						<&funnel_apss_in_funnel_ete>;
> +				};
> +			};
> +		};
> +
> +		in-ports {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +
> +			port@0 {
> +				reg = <0>;
> +				funnel_ete_in_ete0: endpoint {
> +					remote-endpoint =
> +						<&ete0_out_funnel_ete>;
> +				};
> +			};
> +
> +			port@1 {
> +				reg = <1>;
> +				funnel_ete_in_ete1: endpoint {
> +					remote-endpoint =
> +						<&ete1_out_funnel_ete>;
> +				};
> +			};
> +
> +			port@2 {
> +				reg = <2>;
> +				funnel_ete_in_ete2: endpoint {
> +					remote-endpoint =
> +						<&ete2_out_funnel_ete>;
> +				};
> +			};
> +
> +			port@3 {
> +				reg = <3>;
> +				funnel_ete_in_ete3: endpoint {
> +					remote-endpoint =
> +						<&ete3_out_funnel_ete>;
> +				};
> +			};
> +
> +			port@4 {
> +				reg = <4>;
> +				funnel_ete_in_ete4: endpoint {
> +					remote-endpoint =
> +						<&ete4_out_funnel_ete>;
> +				};
> +			};
> +
> +			port@5 {
> +				reg = <5>;
> +				funnel_ete_in_ete5: endpoint {
> +					remote-endpoint =
> +						<&ete5_out_funnel_ete>;
> +				};
> +			};
> +
> +			port@6 {
> +				reg = <6>;
> +				funnel_ete_in_ete6: endpoint {
> +					remote-endpoint =
> +						<&ete6_out_funnel_ete>;
> +				};
> +			};
> +
> +			port@7 {
> +				reg = <7>;
> +				funnel_ete_in_ete7: endpoint {
> +					remote-endpoint =
> +						<&ete7_out_funnel_ete>;
> +				};
> +			};
> +		};
> +	};
> +
>  	firmware {
>  		scm: scm {
>  			compatible = "qcom,scm-sm8450", "qcom,scm";
> @@ -4141,6 +4327,546 @@ data-pins {
>  			};
>  		};
>  
> +		stm@...02000 {
> +			compatible = "arm,coresight-stm", "arm,primecell";
> +			reg = <0x0 0x10002000 0x0 0x1000>,
> +				<0x0 0x16280000 0x0 0x180000>;
> +			reg-names = "stm-base", "stm-stimulus-base";
> +
> +			clocks = <&aoss_qmp>;
> +			clock-names = "apb_pclk";
> +
> +			out-ports {
> +				port {
> +					stm_out_funnel_in0: endpoint {
> +						remote-endpoint =
> +							<&funnel_in0_in_stm>;
> +					};
> +				};
> +			};
> +		};
> +
> +		funnel@...41000 {
> +			compatible = "arm,coresight-dynamic-funnel", "arm,primecell";
> +			reg = <0x0 0x10041000 0x0 0x1000>;
> +
> +			clocks = <&aoss_qmp>;
> +			clock-names = "apb_pclk";
> +
> +			in-ports {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
> +				port@7 {
> +					reg = <7>;
> +					funnel_in0_in_stm: endpoint {
> +						remote-endpoint =
> +							<&stm_out_funnel_in0>;
> +					};
> +				};
> +			};
> +
> +			out-ports {
> +				port {
> +					funnel_in0_out_funnel_qdss: endpoint {
> +						remote-endpoint =
> +							<&funnel_qdss_in_funnel_in0>;
> +					};
> +				};
> +			};
> +		};
> +
> +		funnel@...42000 {
> +			compatible = "arm,coresight-dynamic-funnel", "arm,primecell";
> +
> +			reg = <0x0 0x10042000 0x0 0x1000>;
> +
> +			clocks = <&aoss_qmp>;
> +			clock-names = "apb_pclk";
> +
> +			in-ports {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
> +				port@4 {
> +					reg = <4>;
> +					funnel_in1_in_funnel_apss: endpoint {
> +						remote-endpoint =
> +							<&funnel_apss_out_funnel_in1>;
> +					};
> +				};
> +
> +				port@6 {
> +					reg = <6>;
> +					funnel_in1_in_funnel_dl_center: endpoint {
> +						remote-endpoint =
> +							<&funnel_dl_center_out_funnel_in1>;
> +					};
> +				};
> +			};
> +
> +			out-ports {
> +				port {
> +					funnel_in1_out_funnel_qdss: endpoint {
> +						remote-endpoint =
> +							<&funnel_qdss_in_funnel_in1>;
> +					};
> +				};
> +			};
> +		};
> +
> +		funnel@...45000 {
> +			compatible = "arm,coresight-dynamic-funnel", "arm,primecell";
> +			reg = <0x0 0x10045000 0x0 0x1000>;
> +
> +			clocks = <&aoss_qmp>;
> +			clock-names = "apb_pclk";
> +
> +			in-ports {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
> +				port@0 {
> +					reg = <0>;
> +					funnel_qdss_in_funnel_in0: endpoint {
> +						remote-endpoint =
> +							<&funnel_in0_out_funnel_qdss>;
> +					};
> +				};
> +
> +				port@1 {
> +					reg = <1>;
> +					funnel_qdss_in_funnel_in1: endpoint {
> +						remote-endpoint =
> +							<&funnel_in1_out_funnel_qdss>;
> +					};
> +				};
> +			};
> +
> +			out-ports {
> +				port {
> +					funnel_qdss_out_funnel_aoss: endpoint {
> +						remote-endpoint =
> +							<&funnel_aoss_in_funnel_qdss>;
> +					};
> +				};
> +			};
> +		};
> +
> +		replicator@...46000 {
> +			compatible = "arm,coresight-dynamic-replicator", "arm,primecell";
> +			reg = <0x0 0x10046000 0x0 0x1000>;
> +
> +			clocks = <&aoss_qmp>;
> +			clock-names = "apb_pclk";
> +
> +			in-ports {
> +				port {
> +					replicator_qdss_in_replicator_swao: endpoint {
> +						remote-endpoint =
> +							<&replicator_swao_out_replicator_qdss>;
> +					};
> +				};
> +			};
> +
> +			out-ports {
> +
> +				port {
> +					replicator_qdss_out_replicator_etr: endpoint {
> +						remote-endpoint =
> +							<&replicator_etr_in_replicator_qdss>;
> +					};
> +				};
> +			};
> +		};
> +
> +		tmc_etr: tmc@...48000 {
> +			compatible = "arm,coresight-tmc", "arm,primecell";
> +			reg = <0x0 0x10048000 0x0 0x1000>;
> +
> +			iommus = <&apps_smmu 0x0600 0>;
> +			arm,buffer-size = <0x10000>;
> +
> +			arm,scatter-gather;
> +			clocks = <&aoss_qmp>;
> +			clock-names = "apb_pclk";
> +
> +			in-ports {
> +				port {
> +					tmc_etr_in_replicator_etr: endpoint {
> +						remote-endpoint =
> +							<&replicator_etr_out_tmc_etr>;
> +					};
> +				};
> +			};
> +		};
> +
> +		replicator@...4e000 {
> +			compatible = "arm,coresight-dynamic-replicator", "arm,primecell";
> +			reg = <0x0 0x1004e000 0x0 0x1000>;
> +
> +			clocks = <&aoss_qmp>;
> +			clock-names = "apb_pclk";
> +
> +			in-ports {
> +				port {
> +					replicator_etr_in_replicator_qdss: endpoint {
> +						remote-endpoint =
> +							<&replicator_qdss_out_replicator_etr>;
> +					};
> +				};
> +			};
> +
> +			out-ports {
> +
> +				port {
> +
> +					replicator_etr_out_tmc_etr: endpoint {
> +						remote-endpoint =
> +							<&tmc_etr_in_replicator_etr>;
> +					};
> +				};
> +			};
> +		};
> +
> +		funnel@...04000 {
> +			compatible = "arm,coresight-dynamic-funnel", "arm,primecell";
> +
> +			reg = <0x0 0x10b04000 0x0 0x1000>;
> +
> +			clocks = <&aoss_qmp>;
> +			clock-names = "apb_pclk";
> +
> +			in-ports {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
> +				port@6 {
> +					reg = <6>;
> +					funnel_aoss_in_tpda_aoss: endpoint {
> +						remote-endpoint =
> +							<&tpda_aoss_out_funnel_aoss>;
> +					};
> +				};
> +
> +				port@7 {
> +					reg = <7>;
> +					funnel_aoss_in_funnel_qdss: endpoint {
> +						remote-endpoint =
> +							<&funnel_qdss_out_funnel_aoss>;
> +					};
> +				};
> +			};
> +
> +			out-ports {
> +				port {
> +					funnel_aoss_out_tmc_etf: endpoint {
> +						remote-endpoint =
> +							<&tmc_etf_in_funnel_aoss>;
> +					};
> +				};
> +			};
> +		};
> +
> +		tmc@...05000 {
> +			compatible = "arm,coresight-tmc", "arm,primecell";
> +			reg = <0x0 0x10b05000 0x0 0x1000>;
> +
> +			clocks = <&aoss_qmp>;
> +			clock-names = "apb_pclk";
> +
> +			in-ports {
> +				port {
> +					tmc_etf_in_funnel_aoss: endpoint {
> +						remote-endpoint =
> +							<&funnel_aoss_out_tmc_etf>;
> +					};
> +				};
> +			};
> +
> +			out-ports {
> +				port {
> +					tmc_etf_out_replicator_swao: endpoint {
> +						remote-endpoint =
> +							<&replicator_swao_in_tmc_etf>;
> +					};
> +				};
> +			};
> +		};
> +
> +		replicator@...06000 {
> +			compatible = "arm,coresight-dynamic-replicator", "arm,primecell";
> +			reg = <0x0 0x10b06000 0x0 0x1000>;
> +
> +			qcom,replicator-loses-context;
> +			clocks = <&aoss_qmp>;
> +			clock-names = "apb_pclk";
> +
> +			in-ports {
> +				port {
> +					replicator_swao_in_tmc_etf: endpoint {
> +						remote-endpoint =
> +							<&tmc_etf_out_replicator_swao>;
> +					};
> +				};
> +			};
> +
> +			out-ports {
> +
> +				port {
> +					replicator_swao_out_replicator_qdss: endpoint {
> +						remote-endpoint =
> +							<&replicator_qdss_in_replicator_swao>;
> +					};
> +				};
> +			};
> +		};
> +
> +		tpda@...08000 {
> +			compatible = "qcom,coresight-tpda", "arm,primecell";
> +
> +			reg = <0x0 0x10b08000 0x0 0x1000>;
> +
> +			clocks = <&aoss_qmp>;
> +			clock-names = "apb_pclk";
> +
> +			in-ports {
> +
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
> +				port@0 {
> +					reg = <0>;
> +					tpda_aoss_in_tpdm_swao_prio_0: endpoint {
> +						remote-endpoint =
> +							<&tpdm_swao_prio_0_out_tpda_aoss>;
> +					};
> +				};
> +
> +				port@4 {
> +					reg = <4>;
> +					tpda_aoss_in_tpdm_swao: endpoint {
> +						remote-endpoint =
> +							<&tpdm_swao_out_tpda_aoss>;
> +					};
> +				};
> +			};
> +
> +			out-ports {
> +
> +				port {
> +					tpda_aoss_out_funnel_aoss: endpoint {
> +						remote-endpoint =
> +							<&funnel_aoss_in_tpda_aoss>;
> +					};
> +				};
> +			};
> +		};
> +
> +		tpdm@...09000 {
> +			compatible = "qcom,coresight-tpdm", "arm,primecell";
> +			reg = <0x0 0x10b09000 0x0 0x1000>;
> +
> +
> +			clocks = <&aoss_qmp>;
> +			clock-names = "apb_pclk";
> +
> +			out-ports {
> +				port {
> +					tpdm_swao_prio_0_out_tpda_aoss: endpoint {
> +						remote-endpoint =
> +							<&tpda_aoss_in_tpdm_swao_prio_0>;
> +					};
> +				};
> +			};
> +		};
> +
> +		tpdm@...0d000 {
> +			compatible = "qcom,coresight-tpdm", "arm,primecell";
> +			reg = <0x0 0x10b0d000 0x0 0x1000>;
> +
> +			clocks = <&aoss_qmp>;
> +			clock-names = "apb_pclk";
> +
> +			out-ports {
> +				port {
> +					tpdm_swao_out_tpda_aoss: endpoint {
> +						remote-endpoint =
> +							<&tpda_aoss_in_tpdm_swao>;
> +					};
> +				};
> +			};
> +		};
> +
> +		tpdm@...28000 {
> +			compatible = "qcom,coresight-tpdm", "arm,primecell";
> +			reg = <0x0 0x10c28000 0x0 0x1000>;
> +
> +			clocks = <&aoss_qmp>;
> +			clock-names = "apb_pclk";
> +
> +			out-ports {
> +				port {
> +					tpdm_dlct_out_tpda_dl_center_26: endpoint {
> +						remote-endpoint =
> +							<&tpda_dl_center_26_in_tpdm_dlct>;
> +					};
> +				};
> +			};
> +		};
> +
> +		tpdm@...29000 {
> +			compatible = "qcom,coresight-tpdm", "arm,primecell";
> +			reg = <0x0 0x10c29000 0x0 0x1000>;
> +
> +			clocks = <&aoss_qmp>;
> +			clock-names = "apb_pclk";
> +
> +			out-ports {
> +				port {
> +					tpdm_ipcc_out_tpda_dl_center_27: endpoint {
> +						remote-endpoint =
> +							<&tpda_dl_center_27_in_tpdm_ipcc>;
> +					};
> +				};
> +			};
> +		};
> +
> +		cti@...2a000 {
> +			compatible = "arm,coresight-cti", "arm,primecell";
> +			reg = <0x0 0x10c2a000 0x0 0x1000>;
> +
> +			clocks = <&aoss_qmp>;
> +			clock-names = "apb_pclk";
> +		};
> +
> +		cti@...2b000 {
> +			compatible = "arm,coresight-cti", "arm,primecell";
> +			reg = <0x0 0x10c2b000 0x0 0x1000>;
> +
> +			clocks = <&aoss_qmp>;
> +			clock-names = "apb_pclk";
> +		};
> +
> +		tpda@...2e000 {
> +			compatible = "qcom,coresight-tpda", "arm,primecell";
> +			reg = <0x0 0x10c2e000 0x0 0x1000>;
> +
> +			clocks = <&aoss_qmp>;
> +			clock-names = "apb_pclk";
> +
> +			in-ports {
> +
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
> +				port@1a {
> +					reg = <26>;
> +					tpda_dl_center_26_in_tpdm_dlct: endpoint {
> +						remote-endpoint =
> +							<&tpdm_dlct_out_tpda_dl_center_26>;
> +					};
> +				};
> +
> +				port@1b {
> +					reg = <27>;
> +					tpda_dl_center_27_in_tpdm_ipcc: endpoint {
> +						remote-endpoint =
> +							<&tpdm_ipcc_out_tpda_dl_center_27>;
> +					};
> +				};
> +			};
> +
> +			out-ports {
> +
> +				port {
> +					tpda_dl_center_out_funnel_dl_center: endpoint {
> +						remote-endpoint =
> +							<&funnel_dl_center_in_tpda_dl_center>;
> +					};
> +				};
> +			};
> +		};
> +
> +		funnel@...2f000 {
> +			compatible = "arm,coresight-dynamic-funnel", "arm,primecell";
> +			reg = <0x0 0x10c2f000 0x0 0x1000>;
> +
> +			clocks = <&aoss_qmp>;
> +			clock-names = "apb_pclk";
> +
> +			in-ports {
> +
> +				port {
> +					funnel_dl_center_in_tpda_dl_center: endpoint {
> +						remote-endpoint =
> +							<&tpda_dl_center_out_funnel_dl_center>;
> +					};
> +				};
> +			};
> +
> +			out-ports {
> +				port {
> +					funnel_dl_center_out_funnel_in1: endpoint {
> +						remote-endpoint =
> +							<&funnel_in1_in_funnel_dl_center>;
> +					};
> +				};
> +			};
> +		};
> +
> +		funnel@...10000 {
> +			compatible = "arm,coresight-dynamic-funnel", "arm,primecell";
> +
> +			reg = <0x0 0x13810000 0x0 0x1000>;
> +
> +			clocks = <&aoss_qmp>;
> +			clock-names = "apb_pclk";
> +
> +			in-ports {
> +
> +				port {
> +					funnel_apss_in_funnel_ete: endpoint {
> +						remote-endpoint =
> +							<&funnel_ete_out_funnel_apss>;
> +					};
> +				};
> +			};
> +
> +			out-ports {
> +				port {
> +					funnel_apss_out_funnel_in1: endpoint {
> +						remote-endpoint =
> +							<&funnel_in1_in_funnel_apss>;
> +					};
> +				};
> +			};
> +		};
> +
> +		cti@...e0000 {
> +			compatible = "arm,coresight-cti", "arm,primecell";
> +			reg = <0x0 0x138e0000 0x0 0x1000>;
> +
> +			clocks = <&aoss_qmp>;
> +			clock-names = "apb_pclk";
> +		};
> +
> +		cti@...f0000 {
> +			compatible = "arm,coresight-cti", "arm,primecell";
> +			reg = <0x0 0x138f0000 0x0 0x1000>;
> +
> +			clocks = <&aoss_qmp>;
> +			clock-names = "apb_pclk";
> +		};
> +
> +		cti@...00000 {
> +			compatible = "arm,coresight-cti", "arm,primecell";
> +			reg = <0x0 0x13900000 0x0 0x1000>;
> +
> +			clocks = <&aoss_qmp>;
> +			clock-names = "apb_pclk";
> +		};
> +
>  		sram@...aa000 {
>  			compatible = "qcom,sm8450-imem", "syscon", "simple-mfd";
>  			reg = <0 0x146aa000 0 0x1000>;
> -- 
> 2.46.0
> 

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ