linux-kernel - Re: [PATCH v2 1/2] dt-bindings: power: add power binding header for RK3562 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f32nzf4x4mhmiyvby7b5g5ypre2457a7ziewglhjqfndfxhhnz@qxfagfw3bcsx>
Date: Fri, 27 Dec 2024 09:31:14 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Kever Yang <kever.yang@...k-chips.com>
Cc: heiko@...ech.de, linux-rockchip@...ts.infradead.org, 
	Finley Xiao <finley.xiao@...k-chips.com>, devicetree@...r.kernel.org, Conor Dooley <conor+dt@...nel.org>, 
	Rob Herring <robh@...nel.org>, linux-kernel@...r.kernel.org, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 1/2] dt-bindings: power: add power binding header for
 RK3562 SoC

On Tue, Dec 24, 2024 at 05:39:19PM +0800, Kever Yang wrote:
> From: Finley Xiao <finley.xiao@...k-chips.com>
> 
> According to a description from TRM, add all the power domains.
> 
> Signed-off-by: Finley Xiao <finley.xiao@...k-chips.com>
> Signed-off-by: Kever Yang <kever.yang@...k-chips.com>
> ---
> 
> Changes in v2:
> - rename to rockchip,rk3562-power.h
> - update the subject
> - use dual license
> 
>  .../dt-bindings/power/rockchip,rk3562-power.h | 35 +++++++++++++++++++
>  1 file changed, 35 insertions(+)


No, where is the actual binding?

Your split of patches is not bisectable, illogical and not helping.
Bindings always go with the drivers.

>  create mode 100644 include/dt-bindings/power/rockchip,rk3562-power.h
> 
> diff --git a/include/dt-bindings/power/rockchip,rk3562-power.h b/include/dt-bindings/power/rockchip,rk3562-power.h
> new file mode 100644
> index 000000000000..d728c9ee908d
> --- /dev/null
> +++ b/include/dt-bindings/power/rockchip,rk3562-power.h
> @@ -0,0 +1,35 @@
> +/* SPDX-License-Identifier: (GPL-2.0 OR MIT) */

And why not license requested by checkpatch?

Best regards,
Krzysztof