linux-kernel - Re: [PATCH v2 11/17] dt-bindings: pwm: rockchip: Add rockchip,rk3562-pwm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <jjz7dk3rr3sruyks6yduwo37fcxqcut3vuqax2m43nvipnqdsu@zxzbddrlzk6j>
Date: Fri, 27 Dec 2024 09:31:17 +0100
From: Uwe Kleine-König <ukleinek@...nel.org>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Kever Yang <kever.yang@...k-chips.com>, heiko@...ech.de, 
	linux-rockchip@...ts.infradead.org, linux-pwm@...r.kernel.org, Conor Dooley <conor+dt@...nel.org>, 
	Rob Herring <robh@...nel.org>, linux-kernel@...r.kernel.org, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 11/17] dt-bindings: pwm: rockchip: Add
 rockchip,rk3562-pwm

On Fri, Dec 27, 2024 at 08:42:30AM +0100, Krzysztof Kozlowski wrote:
> On Tue, Dec 24, 2024 at 05:49:14PM +0800, Kever Yang wrote:
> > Add rockchip,rk3562-pwm compatible string.
> 
> This we see from the diff. Say something not obvious. Where is the
> driver change? Why devices are or are not compatible?

There is no driver change necessary because the newly supported
compatible is

	compatible = "rockchip,rk3562-pwm", "rockchip,rk3328-pwm";

Indeed this could be made more obvious in the commit log, something
like:

	The PWM core on Rockchip's RK3562 is the same as the one already
	included in RK3328. Extend the binding accordingly to allow

		compatible = "rockchip,rk3562-pwm", "rockchip,rk3328-pwm";

Best regards
Uwe

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)